Bug 245363

Summary:	Cleanup RenderLayer::updateLayerPosition()
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	Layout and Rendering	Assignee:	Nikolas Zimmermann <zimmermann>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, rbuis, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Description Nikolas Zimmermann 2022-09-19 06:41:13 PDT

- Avoid unnecessary LayoutSize <-> LayoutPoint conversions
- Use dynamicDowncast() where possible
- Code de-duplication (re-use checks from RenderLayerCompositor)
- Remove inlineBoundingBoxOffset hack from updateLayerPosition(), no longer needed
- Refactor layer size & location computation to be less intrusive

Comment 1 Nikolas Zimmermann 2022-09-19 06:50:39 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4483

Comment 2 Nikolas Zimmermann 2022-09-19 14:45:47 PDT

This is part of the work done for LBSE, but doesn't "block" bug 90738, removing that dependency again.

Comment 3 Radar WebKit Bug Importer 2022-09-26 06:42:17 PDT

<rdar://problem/100408829>

Comment 4 EWS 2022-11-19 17:17:46 PST

Committed 256880@main (6eebc817120b): <https://commits.webkit.org/256880@main>

Reviewed commits have been landed. Closing PR #4483 and removing active labels.