Bug 245362

Summary:	Use dynamicDowncast() in RenderBox::offsetFromContainer()
Product:	WebKit	Reporter:	Nikolas Zimmermann <zimmermann>
Component:	Layout and Rendering	Assignee:	Nikolas Zimmermann <zimmermann>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, rbuis, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified

Description Nikolas Zimmermann 2022-09-19 06:33:01 PDT

When both if<Foo> + downcast<Foo> are used, dynamicDowncast() is preferred (less repetitive).

Comment 1 Nikolas Zimmermann 2022-09-19 06:34:30 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4482

Comment 2 EWS 2022-09-19 14:03:46 PDT

Committed 254644@main (cfb088fd5663): <https://commits.webkit.org/254644@main>

Reviewed commits have been landed. Closing PR #4482 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-09-19 14:04:25 PDT

<rdar://problem/100138658>

Comment 4 Nikolas Zimmermann 2022-09-19 14:45:33 PDT

Well, this is part of the work done for LBSE, but doesn't "block" bug 90738, removing that dependency again.