Bug 245333

Summary:	REGRESSION(254574@main): Triggers ASSERTS when running wpt tests
Product:	WebKit	Reporter:	Philippe Normand <philn>
Component:	WebKitGTK	Assignee:	Philippe Normand <philn>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Philippe Normand 2022-09-18 04:28:13 PDT

Doing an ASSERT_NOT_REACHED() for a feature not implemented seems a bit odd. Usually notImplemented() is used instead.

Test: imported/w3c/web-platform-tests/css/css-pseudo/highlight-paired-cascade-004.html and more

STDERR: SHOULD NEVER BE REACHED
STDERR: /app/webkit/Source/WebKit/UIProcess/WebPageProxy.cpp(7093) : void WebKit::WebPageProxy::setTextIndicator(const WebCore::TextIndicatorData&, uint64_t)

Comment 1 Philippe Normand 2022-09-18 04:42:38 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4456

Comment 2 EWS 2022-09-18 08:19:08 PDT

Committed 254610@main (b8caa5b21cd3): <https://commits.webkit.org/254610@main>

Reviewed commits have been landed. Closing PR #4456 and removing active labels.