Bug 245301
| Summary: | Complete id-ref reflection implementation for ARIAAttributes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Accessibility | Assignee: | Ryosuke Niwa <rniwa> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | andresg_22, rego, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | 244972, 245299, 245467 | ||
| Bug Blocks: | 196843 | ||
Ryosuke Niwa
The implementation of id-ref reflection is incomplete.
We need to finish this work before we can ship this feature.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/100042185>
Manuel Rego Casasnovas
Thanks for filling the issues.
(In reply to Ryosuke Niwa from comment #0)
> The implementation of id-ref reflection is incomplete.
> We need to finish this work before we can ship this feature.
Should we switch off AriaReflectionForElementReferencesEnabled flag until these issues are fixed?
Ryosuke Niwa
(In reply to Manuel Rego Casasnovas from comment #2)
> Thanks for filling the issues.
>
> (In reply to Ryosuke Niwa from comment #0)
> > The implementation of id-ref reflection is incomplete.
> > We need to finish this work before we can ship this feature.
>
> Should we switch off AriaReflectionForElementReferencesEnabled flag until
> these issues are fixed?
I'd recommend that given the primary motivation of element reflection was making ARIA work with shadow DOM.
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/4660
EWS
Test gardening commit 254818@main (9dc671ed1a7b): <https://commits.webkit.org/254818@main>
Reviewed commits have been landed. Closing PR #4660 and removing active labels.
EWS
Committed 255358@main (3de868265f67): <https://commits.webkit.org/255358@main>
Reviewed commits have been landed. Closing PR #5179 and removing active labels.