Bug 245230

Summary:	[Filters] Limit the memory cost of FilterResults to 100MB
Product:	WebKit	Reporter:	Said Abou-Hallawa <sabouhallawa>
Component:	Layout and Rendering	Assignee:	Said Abou-Hallawa <sabouhallawa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, simon.fraser, webkit-bug-importer, zalan
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	242219

Description Said Abou-Hallawa 2022-09-15 10:01:03 PDT

Allowing to cache many large FilterImages can cause a memory jetsam. We tried to solve this problem by not applying the filter if the number of filter effects exceeds a certain maximum (currently it is 100).

Instead we should look at the estimated total memory size if we cache all the results. But even if we decide to no cache the result because their memory will exceed a certain maximum (say 100 MB), we should still apply the SVGFilter without caching the results. This may be very inefficient especially with cases where a result FilterImage is used multiple times. Caching it saves time, but we have to regenerate it every time we need it. Of course this is better than not displaying anything for the filtered image.

Comment 1 Radar WebKit Bug Importer 2022-09-15 10:18:10 PDT

<rdar://problem/99975678>

Comment 2 Said Abou-Hallawa 2022-09-15 10:24:30 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4390

Comment 3 EWS 2023-06-01 14:47:42 PDT

Committed 264807@main (93ee37d30632): <https://commits.webkit.org/264807@main>

Reviewed commits have been landed. Closing PR #4390 and removing active labels.