Bug 245205

Summary:	Align "UA" stylesheet for hidden elements with HTML Spec and consolidate "display: none"
Product:	WebKit	Reporter:	Ahmad Saleem <ahmad.saleem792>
Component:	CSS	Assignee:	Ahmad Saleem <ahmad.saleem792>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	2843035794, karlcow, ntim, simon.fraser, webkit-bug-importer
Priority:	P2	Keywords:	BrowserCompat, InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified

Description Ahmad Saleem 2022-09-14 17:06:44 PDT

I noticed that we are failing few WPT tests:

https://wpt.fyi/results/html/rendering/non-replaced-elements/hidden-elements.html?label=master&label=experimental&aligned&view=subtest&q=hidden%20element

Because we don't have those elements defined as "display: none" in html.css like other browser engines 'Gecko' and 'Blink'.

This bug is to add the missing and also consolidate already used 'display: none' in one go to make it easier to read and manage.

I am going to follow web-spec:

https://html.spec.whatwg.org/#hidden-elements

In case, if I am not able to do it and had to close my PR, I will share details on genuine test failures or why this is no go at the moment for Webkit so someone else can take a look in future.

Thanks!

Comment 1 Tim Nguyen (:ntim) 2022-09-15 09:09:40 PDT

https://github.com/WebKit/WebKit/pull/4370

Comment 2 Fujii Hironori 2022-09-15 13:46:31 PDT

*** Bug 242101 has been marked as a duplicate of this bug. ***

Comment 3 EWS 2022-09-16 23:23:46 PDT

Committed 254584@main (f02c256038a1): <https://commits.webkit.org/254584@main>

Reviewed commits have been landed. Closing PR #4370 and removing active labels.

Comment 4 Radar WebKit Bug Importer 2022-09-16 23:24:17 PDT

<rdar://problem/100059760>