Bug 245177

Summary:	Refactor CSSTransition::create() to only take RenderStyle references
Product:	WebKit	Reporter:	Antoine Quint <graouts>
Component:	Animations	Assignee:	Antoine Quint <graouts>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dino, graouts, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Antoine Quint

Reported 2022-09-14 05:58:26 PDT

Currently CSSTransition::create() takes a RenderStyle* for the oldStyle parameter, but it makes no sense since a transition necessarily operates on an underlying style. This should be a RenderStyle&.

Attachments
Add attachment proposed patch, testcase, etc.

Antoine Quint

Comment 1 2022-09-14 06:02:13 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4344

EWS

Comment 2 2022-09-15 02:11:03 PDT

Committed 254510@main (e65b4584d9c6): <https://commits.webkit.org/254510@main> Reviewed commits have been landed. Closing PR #4344 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-09-15 02:12:18 PDT

<rdar://problem/99959496>

Note You need to log in before you can comment on or make changes to this bug.