Bug 245122

Summary:	Percentage-based translations don't work with SVG <text>
Product:	WebKit	Reporter:	Tim Nguyen (:ntim) <ntim>
Component:	Layout and Rendering	Assignee:	Tim Nguyen (:ntim) <ntim>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bfulgham, commit-queue, rbuis, simon.fraser, webkit-bug-importer, zalan, zimmermann
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	245499
Bug Blocks:

Description Tim Nguyen (:ntim) 2022-09-12 21:57:40 PDT

Affected WPT:

css/css-transforms/transform-box/view-box-mutation-002.html: https://wpt.live/css/css-transforms/transform-box/view-box-mutation-002.html
css/css-transforms/transform-box/view-box-mutation-003.html: https://wpt.live/css/css-transforms/transform-box/view-box-mutation-003.html

Both tests exercise transform: translate(-50%, 0) and transform-box

Comment 1 Radar WebKit Bug Importer 2022-09-12 21:58:10 PDT

<rdar://problem/99854408>

Comment 2 Tim Nguyen (:ntim) 2022-09-14 10:40:12 PDT


*** This bug has been marked as a duplicate of bug 245120 ***

Comment 3 Tim Nguyen (:ntim) 2022-09-15 08:48:58 PDT

The issue here is separate from bug 245120.

We pass in a 0x0 rect as bounding box rect for transforms: https://searchfox.org/wubkat/rev/0c40ba62b482511fe03646f1d4982efd727475dd/Source/WebCore/svg/SVGTextElement.cpp#59

Similar issue occurs with <foreignobject>

Comment 4 Tim Nguyen (:ntim) 2022-09-15 16:20:11 PDT

bug 245120 fixes foreignObject

Comment 5 Tim Nguyen (:ntim) 2022-09-15 16:33:49 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4408

Comment 6 EWS 2022-09-19 19:21:40 PDT

Committed 254656@main (b87209ee89e8): <https://commits.webkit.org/254656@main>

Reviewed commits have been landed. Closing PR #4408 and removing active labels.

Comment 7 WebKit Commit Bot 2022-09-21 12:15:20 PDT

Re-opened since this is blocked by bug 245499

Comment 8 Tim Nguyen (:ntim) 2022-09-22 14:00:00 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4607

Comment 9 EWS 2022-09-22 20:58:23 PDT

Committed 254777@main (ec9527d7aa0c): <https://commits.webkit.org/254777@main>

Reviewed commits have been landed. Closing PR #4607 and removing active labels.