Bug 245042

Summary:	Avoid constructing InputType in HTMLInputElement::updateType whenever possible
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	DOM	Assignee:	Ryosuke Niwa <rniwa>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, heycam, webkit-bug-importer, ysuzuki
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Ryosuke Niwa

Reported 2022-09-10 20:25:30 PDT

Right now, HTMLInputElement::updateType always creates InputType of the new type just to check whether the type string has changed or not. Avoid this construction as a perf optimization.

Attachments
Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2022-09-10 20:29:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4231

EWS

Comment 2 2022-09-12 08:51:01 PDT

Committed 254383@main (62339dafa6fc): <https://commits.webkit.org/254383@main> Reviewed commits have been landed. Closing PR #4231 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-09-12 08:52:20 PDT

<rdar://problem/99823605>

Note You need to log in before you can comment on or make changes to this bug.