Bug 245019

Summary: Use 'break' instead of 'continue' in a 'do { } while (false)' loop
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: MediaAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description David Kilzer (:ddkilzer) 2022-09-09 21:09:17 PDT 
Use 'break' instead of 'continue' in a 'do { } while (false)' loop.

In Source/WebCore/Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

```
bool CDMSessionClearKey::update(Uint8Array* rawKeysData, RefPtr<Uint8Array>& nextMessage, unsigned short& errorCode, uint32_t& systemCode)
{
    [...]

    do {
        auto rawKeysString = String::fromUTF8(rawKeysData->data(), rawKeysData->length());
        if (rawKeysString.isEmpty())  {
            LOG(Media, "CDMSessionClearKey::update(%p) - failed: empty message", this);
            continue;
        }
        [...]
    } while (false);

    [...]
}
```

Found by CodeQL.
Comment 1 Radar WebKit Bug Importer 2022-09-09 21:09:39 PDT 
<rdar://problem/99770949>
Comment 2 David Kilzer (:ddkilzer) 2022-09-09 21:14:44 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4213
Comment 3 EWS 2022-09-12 11:04:10 PDT 
Committed 254393@main (4c4c0a117195): <https://commits.webkit.org/254393@main>

Reviewed commits have been landed. Closing PR #4213 and removing active labels.