Bug 245018

Summary: angle_version.h and angle_version_info.h should not use the same header guard macro
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, kbr, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description David Kilzer (:ddkilzer) 2022-09-09 20:56:36 PDT 
angle_version.h and angle_version_info.h should not use the same header guard macro.

Currently they both use:

#ifndef COMMON_VERSION_H_
#define COMMON_VERSION_H_
[...]
#endif  // COMMON_VERSION_H_

Found by CodeQL.
Comment 1 Radar WebKit Bug Importer 2022-09-09 20:57:01 PDT 
<rdar://problem/99770768>
Comment 2 David Kilzer (:ddkilzer) 2022-09-09 21:00:51 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/4212
Comment 3 EWS 2022-09-11 22:46:57 PDT 
Committed 254370@main (1a61b3dac3ce): <https://commits.webkit.org/254370@main>

Reviewed commits have been landed. Closing PR #4212 and removing active labels.