Bug 244988
| Summary: | Always emit JavaScript signposts | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Misc. | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Local Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ben Nham
In bug 244006 we conditionalized emitting os_signposts based on the DBG_APPS kdebug class. This is not necessary for JavaScript signposts since the JS signposts are already conditionalized behind the exposeProfilersOnGlobalObject option. Another issue here is that Instruments doesn't enable the DBG_APPS kdebug class by default, and some members of the JSC team prefer using Instruments. This means that the JS signposts end up not being emitted at all. Fix this by always emitting signposts from the JS API.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/99750295>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/4176
EWS
Committed 254445@main (00a2349badb3): <https://commits.webkit.org/254445@main>
Reviewed commits have been landed. Closing PR #4176 and removing active labels.