Bug 244983

Summary:	REGRESSION (252480@main?): [ BigSur wk2 Release ] Seven webgl/2.0.0/deqp/functional/gles3/uniform tests are a flaky failure
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	WebGL	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	dino, kbr, kkinnunen, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=244980 https://bugs.webkit.org/show_bug.cgi?id=245022

Description Karl Rackler 2022-09-09 09:01:51 PDT

Description:
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/instance_array_basic_type.html
webgl/2.0.0/deqp/functional/gles3/uniformapi/value_initial.html
webgl/2.0.0/deqp/functional/gles3/uniformapi/random.html

These tests were passing consistently until approximately at 252487@main when they began to flaky fail. 

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=webgl%2F2.0.0%2Fdeqp%2Ffunctional%2Fgles3%2Funiformapi%2Frandom.html&test=webgl%2F2.0.0%2Fdeqp%2Ffunctional%2Fgles3%2Funiformapi%2Fvalue_initial.html&test=webgl%2F2.0.0%2Fdeqp%2Ffunctional%2Fgles3%2Funiformbuffers%2Finstance_array_basic_type.html

Diff:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests/252487@main%20(8643)/webgl/2.0.0/deqp/functional/gles3/uniformapi/random-diff.txt
https://build.webkit.org/results/Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests/252501@main%20(8652)/webgl/2.0.0/deqp/functional/gles3/uniformbuffers/instance_array_basic_type-diff.txt
https://build.webkit.org/results/Apple-BigSur-Release-WK2-WebGL-GPUProcess-Tests/252490@main%20(8646)/webgl/2.0.0/deqp/functional/gles3/uniformapi/value_initial-diff.txt

Comment 1 Radar WebKit Bug Importer 2022-09-09 09:02:30 PDT

<rdar://problem/99746589>

Comment 2 Karl Rackler 2022-09-09 09:05:34 PDT

I have marked this test as a flaky failure while this issue is investigated.

Comment 3 EWS 2022-09-09 09:11:49 PDT

Test gardening commit 254302@main (7ae389e979b0): <https://commits.webkit.org/254302@main>

Reviewed commits have been landed. Closing PR #4173 and removing active labels.

Comment 4 Karl Rackler 2022-09-09 16:39:24 PDT

These two test appear to have the same estimated regression point:
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/single_nested_struct.html
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/multi_nested_struct.html

Comment 5 Karl Rackler 2022-09-09 16:39:48 PDT

Update expectations.

Comment 6 EWS 2022-09-09 16:46:32 PDT

Test gardening commit 254338@main (a712cd03c4bf): <https://commits.webkit.org/254338@main>

Reviewed commits have been landed. Closing PR #4205 and removing active labels.

Comment 7 Alexey Proskuryakov 2022-09-09 18:59:22 PDT

252487@main was "Add support for WPT style test-wait class name". 

Looking at the diff, I don't see how it have could possibly caused such failures. But test result history does suggest that this started within a few revisions from that.

252480@main was the closest WebGL change before the failures started.

Comment 8 Karl Rackler 2022-09-12 05:46:29 PDT

252480@main WebGL change does make sense.

Comment 9 Karl Rackler 2022-09-12 07:48:11 PDT

Adding addition tests: 
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/single_struct_array.html
webgl/2.0.0/deqp/functional/gles3/uniformapi/value_assigned.html
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/single_basic_array.html

I have marked this test as a flaky failure/ while this issue is investigated.

Comment 10 EWS 2022-09-12 08:00:10 PDT

Test gardening commit 254381@main (58911c9b8706): <https://commits.webkit.org/254381@main>

Reviewed commits have been landed. Closing PR #4260 and removing active labels.

Comment 11 Karl Rackler 2022-09-13 07:18:35 PDT

adding additional test:
webgl/2.0.0/deqp/functional/gles3/uniformbuffers/single_struct.html

Comment 12 EWS 2022-09-13 07:24:17 PDT

Test gardening commit 254441@main (f15b8ea18788): <https://commits.webkit.org/254441@main>

Reviewed commits have been landed. Closing PR #4310 and removing active labels.

Comment 13 Karl Rackler 2022-09-13 13:23:11 PDT


*** This bug has been marked as a duplicate of bug 244979 ***