Bug 244982

Summary: css-pseudo: ::placeholder should not support 'writing-mode', 'direction', and 'text-orientation'
Product: WebKit Reporter: Ahmad Saleem <ahmad.saleem792>
Component: CSSAssignee: Ahmad Saleem <ahmad.saleem792>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, bfulgham, karlcow, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: BrowserCompat, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Ahmad Saleem 2022-09-09 08:23:51 PDT 
It is to align Webkit with Web-Spec:

https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo
> All properties that apply to the ::first-line pseudo-element also apply to the ::placeholder pseudo-element.

and
https://drafts.csswg.org/css-pseudo-4/#first-line-styling
> User agents may apply other properties as well except for the following excluded properties:
> * writing-mode
> * direction
> * text-orientation

Current Safari Technology Preview 153 behavior is not aligned with Blink / Chromium, Gecko / Firefox and Web-Spec.

Chrome Commit to Merge - https://chromium.googlesource.com/chromium/src.git/+/68c32d4e9fe24e25e672095253e0f0b2e709ecf4%5E%21/

Where to merge - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/css/html.css#L762

Thanks!
Comment 1 Ahmad Saleem 2022-09-10 06:38:47 PDT 
It seems that it does not fix WPT test but since it is to align with web-spec, I think it is still good to merge this change. So I pushed it without change request and let's see. Thanks!
Comment 2 Ahmad Saleem 2022-09-10 06:39:12 PDT 
https://github.com/WebKit/WebKit/pull/4172
Comment 3 EWS 2022-09-12 17:42:41 PDT 
Committed 254416@main (b79ce718736d): <https://commits.webkit.org/254416@main>

Reviewed commits have been landed. Closing PR #4172 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2022-09-12 17:43:18 PDT 
<rdar://problem/99846286>
Comment 5 Karl Dubost 2022-09-16 16:12:00 PDT 
Ahmad do you remember which WPT test is you were alluding to?
Comment 6 Ahmad Saleem 2022-09-16 23:12:22 PDT 
(In reply to Karl Dubost from comment #5)
> Ahmad do you remember which WPT test is you were alluding to?

https://wpt.fyi/results/css/css-pseudo/placeholder-excluded-properties.html?label=master&label=experimental&aligned&view=subtest&q=placeholder-excluded-properties