Bug 244960

Summary:	Revision field in the json data generated by run-webkit-tests is empty since migration to git
Product:	WebKit	Reporter:	Carlos Alberto Lopez Perez <clopez>
Component:	Tools / Tests	Assignee:	Carlos Alberto Lopez Perez <clopez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	aakash_jain, dewei_zhu, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://github.com/clopez/webkit-testhunter/issues/11

Description Carlos Alberto Lopez Perez 2022-09-08 20:53:35 PDT

run-webkit-tests generates a json file with the information of the run (usually named full_results.json)

This json included a "revision" field with the SVN revision of the checkout where the run was executed. But since the migration to git this "revision" field is null.

See example: https://build.webkit.org/results/GTK-Linux-64-bit-Release-GTK4-Tests/254161%40main%20%2825393%29/full_results.json (See the "revision" key at the end of the json)

This issue broke the webkit-testhunter tool that relied on this field to index and sort the runs. See: https://github.com/clopez/webkit-testhunter/issues/11

Comment 1 Carlos Alberto Lopez Perez 2022-09-08 21:09:02 PDT

Pull request: https://github.com/WebKit/WebKit/pull/4152

Comment 2 EWS 2022-09-12 04:32:00 PDT

Committed 254376@main (ee1be476e83b): <https://commits.webkit.org/254376@main>

Reviewed commits have been landed. Closing PR #4152 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-09-12 04:32:18 PDT

<rdar://problem/99817002>