| Summary: | Broken preprocessor directive in WebKitWebViewBase.cpp causes build failure | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dave | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Local Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Should have mentioned, this is for WebKit 2.36.7 UPDATE: Something about this wasn't sitting right with me, so I went back and investigated further. If anyone has looked into this so far you'd probably be wondering "WTF?" It turns out that a patch I had *previously* created to fix an 'accessibility disabled' build failure in an earlier WebKit, was still being "successfully" applied, though it was now no longer needed because the bug was finally patched. This caused a really bizarre patched code output, which then require this new "patch" to "fix". So the actual original problem here is that WebKit 2.36.0 went out the door with broken no-accessibility build. I made a patch to fix it, which continued being applied through 2.36.3; but it was fixed somewhere between there and 2.36.7. Well, it's good that the original bug was finally patched--but it should have never been in there in the first place. WebKit is building now and I will close the bug if/when it completes successfully. OK, fixed. |
Created attachment 462204 [details] Fix preprocessor statements Corrected two very poorly placed #if and #endif statements, which causes a build error when accessibility is disabled. This is yet another example of the need for automated build testing of non-default WebKit configurations, to reveal such ridiculous errors *before* release. Always looking forward to a new WebKit-GTK release, to see how many patches I will have to write just to get it to compile! [boilerplate disclaimer: I hereby disclaim any ownership "rights" to this patch. You can use it freely.]