| Summary: | IPC::Attachment is used as an encoded type on Darwin and Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> |
| Component: | WebKit2 | Assignee: | Kimmo Kinnunen <kkinnunen> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Pull request: https://github.com/WebKit/WebKit/pull/4090 Committed 254379@main (5540bc1e9de4): <https://commits.webkit.org/254379@main> Reviewed commits have been landed. Closing PR #4090 and removing active labels. |
IPC::Attachment is used as an encoded object The original intent is that IPC::Attachment is an attachment to the IPC message. Attachments are needed for those objects that cannot be transferred as data. Incorrect: Encode Connection port: - Interpret the Connection port as an Attachment - Encode the Attachment - Attachment::encode attaches the attachment to the Encoder attachments list Correct: Encode Connection port: - Construct an Attachment from the Connection port - Attach the Attachment to the Encoder attachments list