| Summary: | [css-contain] Fix contain-inline-size-replaced.html | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||||||||||
| Component: | CSS | Assignee: | Rob Buis <rbuis> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | changseok, clopez, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, ntim, pdr, webkit-bug-importer, youennf, zalan | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | Safari 15 | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
Rob Buis
2022-09-05 03:23:12 PDT
Created attachment 462140 [details]
Patch
Created attachment 462147 [details]
Patch
Created attachment 462160 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Created attachment 462164 [details]
Patch
Created attachment 462168 [details]
Patch
Comment on attachment 462168 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462168&action=review r=me > Source/WebCore/rendering/RenderReplaced.cpp:572 > + if (shouldApplyInlineSizeContainment()) > + return { }; You're using `{ }` here and `LayoutUnit()` above, can you be consistent if they're equivalent? Created attachment 462176 [details]
Patch
Created attachment 462178 [details]
Patch
Committed 254226@main (113089411a3a): <https://commits.webkit.org/254226@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462178 [details]. |