| Summary: | REGRESSION (253628@main): Missing images on bbc.com pages | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | Images | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | changseok, darin, esprehn+autocc, ews-watchlist, glenn, karlcow, kondapallykalyan, pdr, rbuis, sabouhallawa, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | BrowserCompat, InRadar | ||||||||
| Version: | Safari Technology Preview | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| URL: | https://www.bbc.com/news/uk-england-london-62786371 | ||||||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=237703 https://bugs.webkit.org/show_bug.cgi?id=244033 |
||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2022-09-04 17:55:44 PDT
Does it work if you deactivate "lazy image loading" in experimental. If yes it could be very similar to Bug 237703 I can't reproduce on Safari Version 16.1 (18614.2.1.1.1) Oddly it still reproduces if I turn off the "Lazy Image Loading" and "Lazy iframe loading" experimental features. I'll try to find the regression point. autospade says this regressed at https://commits.webkit.org/253628@main Created attachment 462148 [details]
Screenrecording
Images do show up initially and they disappear after a few seconds.
Images end up with 0px height (width: 100%; height: 100%). We are probably missing an integration piece where the out-of-flow renderer's height is computed after the inline layout (sizing the out-of-flow content is not part of the inline layout, only finding its static position is). Created attachment 462152 [details]
Test reduction
We fail to resolve the percent height when the IFC root is also the containing block for the out-of-flow box (e.g. <div style="position: relative">out-of-flow -> <div style="height: 10%; position: absolute"></div>) Created attachment 462154 [details]
Patch
Committed 254176@main (fee10597718f): <https://commits.webkit.org/254176@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462154 [details]. |