Bug 244748

Summary: [LFC][IFC] Make LineBuilder::layoutInlineContent more readable
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
[fast-cq]Patch none

Description zalan 2022-09-02 19:14:59 PDT 
ssia
Comment 1 zalan 2022-09-02 19:19:22 PDT 
Created attachment 462109 [details]
Patch
Comment 2 Antti Koivisto 2022-09-04 07:41:06 PDT 
Comment on attachment 462109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462109&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:-325
> -    auto computedVisualOrder = [&]() -> Vector<int32_t> {

Lambdas are so last season.
Comment 3 zalan 2022-09-04 09:22:31 PDT 
Created attachment 462118 [details]
Patch
Comment 4 zalan 2022-09-04 09:23:16 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 462109 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=462109&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp:-325
> > -    auto computedVisualOrder = [&]() -> Vector<int32_t> {
> 
> Lambdas are so last season.
Embarrassingly last season.
Comment 5 EWS 2022-09-04 10:32:36 PDT 
Committed 254145@main (7ee3116d443d): <https://commits.webkit.org/254145@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462118 [details].
Comment 6 Radar WebKit Bug Importer 2022-09-04 10:33:16 PDT 
<rdar://problem/99547501>
Comment 7 zalan 2022-09-04 12:39:32 PDT 
Reopening to attach new patch.
Comment 8 zalan 2022-09-04 12:39:34 PDT 
Created attachment 462128 [details]
[fast-cq]Patch
Comment 9 EWS 2022-09-04 12:51:15 PDT 
Committed 254148@main (31b496983b2d): <https://commits.webkit.org/254148@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462128 [details].