| Summary: | [LFC][IFC] Introduce the concept of "placed" float boxes | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2022-09-02 16:31:36 PDT
Created attachment 462107 [details]
Patch
Comment on attachment 462107 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462107&action=review > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66 > + using FloatList = Vector<const InlineItem*>; I suppose the type could also be PlacedFloats because that is the only thing it is used for (for now?). or PlacedFloatItems or something (In reply to Antti Koivisto from comment #2) > Comment on attachment 462107 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=462107&action=review > > > Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.h:66 > > + using FloatList = Vector<const InlineItem*>; > > I suppose the type could also be PlacedFloats because that is the only thing > it is used for (for now?). The upcoming patch with "overflowing floats" gonna use this type. Created attachment 462122 [details]
Patch
Created attachment 462124 [details]
Patch
Committed 254151@main (7bdac4ad13a4): <https://commits.webkit.org/254151@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462124 [details]. |