Bug 244714

Summary:

REGRESSION (253726@main): [ macOS wk1 Debug ] ASSERTION FAILED: !needsLayout() WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)

Product:

WebKit

Reporter:

Karl Rackler <rackler>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

bfulgham, hi, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=244676
https://bugs.webkit.org/show_bug.cgi?id=244696
https://bugs.webkit.org/show_bug.cgi?id=244693
https://bugs.webkit.org/show_bug.cgi?id=244886

Attachments:

Description	Flags
test-list	none
symbolicated-log	none

Description Karl Rackler 2022-09-02 08:18:34 PDT

Description:
imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html is a flaky crash

The test consistently passed until the first flaky crash a saw on the dashboard at 246850@main.  The test continues to flaky crash until, at 253726@main, the frequency of flaky crashes increases significantly.  

REPRODUCTION STEPS
I can reproduce the flaky crash at 253726@main but cannot reproduce it at 253725@main or earlier.

Command: 
run-webkit-tests --debug -1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --child-processes 1 --test-list <test-list attached>

Result: 
Unexpected flakiness: crashes (1)
  imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html [ Pass Crash ]

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fbrowsers%2Fbrowsing-the-web%2Fread-media%2Fpageload-video.html&platform=mac&style=debug&flavor=wk1&limit=50000&recent=false

Crash Log:
Thread 0 Crashed::  
0   com.apple.JavaScriptCore      	       0x121b68f4e    WTFCrash
1   com.apple.WebCore             	       0x13153839a    WTFCrashWithInfo(int, char const*, char const*, int)
2   com.apple.WebCore             	       0x135d7094e    WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
3   com.apple.WebKitLegacy        	       0x1075c8a1c    -[WebFrame(WebInternal) _drawRect:contentsOnly:]
4   com.apple.WebKitLegacy        	       0x1075ec9d2    -[WebHTMLView drawSingleRect:]
5   com.apple.WebKitLegacy        	       0x1075ed034    -[WebHTMLView drawRect:]
6   com.apple.AppKit              	       0x7ff80bec3280 _NSViewDrawRect + 120 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:992)
7   com.apple.AppKit              	       0x7ff80c5de3bc -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 1826 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:16555)
8   com.apple.WebKitLegacy        	       0x1075e07c6    -[WebHTMLView(WebPrivate) _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
9   com.apple.AppKit              	       0x7ff80c5de70a -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 2672 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:16588)
10  com.apple.AppKit              	       0x7ff80c5de70a -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 2672 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:16588)
11  com.apple.AppKit              	       0x7ff80c5de70a -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:] + 2672 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:16588)
12  com.apple.AppKit              	       0x7ff80c033194 -[NSView displayRectIgnoringOpacity:inContext:] + 824 (/AppleInternal/Library/BuildRoots/dd001be1-8f4d-11ec-b343-4a23b0182bfd/Library/Caches/com.apple.xbs/Sources/AppKit/AppKit.subproj/NSView.m:10319)
13  com.apple.WebCore             	       0x133c3951c    WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
14  com.apple.WebCore             	       0x13602c482    WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
15  com.apple.WebCore             	       0x136b5a108    WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
16  com.apple.WebCore             	       0x136b5a9c2    WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)

Comment 1 Radar WebKit Bug Importer 2022-09-02 08:18:54 PDT

<rdar://problem/99489783>

Comment 2 Karl Rackler 2022-09-02 08:22:15 PDT

Created attachment 462096 [details]
test-list

Comment 3 Karl Rackler 2022-09-02 08:22:44 PDT

Created attachment 462097 [details]
symbolicated-log

Comment 4 Karl Rackler 2022-09-02 08:23:27 PDT

I have marked this test as a flaky crash while this issue is investigated.

Comment 5 EWS 2022-09-02 08:30:18 PDT

Test gardening commit 254101@main (ae96f908e4ef): <https://commits.webkit.org/254101@main>

Reviewed commits have been landed. Closing PR #3957 and removing active labels.

Comment 6 Karl Rackler 2022-09-07 05:56:10 PDT

Skipping test affected by wk1 debug only assertion caused by underlying issue.
https://github.com/WebKit/WebKit/pull/4093