Bug 244706

Summary: CSS - overflow: clip is not working on SVG elements
Product: WebKit Reporter: Karl Dubost <karlcow>
Component: CSSAssignee: Rob Buis <rbuis>
Status: RESOLVED FIXED    
Severity: Normal CC: cathiechen, changseok, clopez, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, rbuis, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, youennf, zimmermann
Priority: P2 Keywords: BrowserCompat, InRadar, SVGHitList
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
URL: https://wpt.fyi/results/svg/render/reftests/overflow-clip.html?label=experimental&label=master&aligned
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Karl Dubost 2022-09-02 01:52:27 PDT 
https://wpt.fyi/results/svg/render/reftests/overflow-clip.html?label=experimental&label=master&aligned

This test fails
http://wpt.live/svg/render/reftests/overflow-clip.html

data:text/html,<svg%20style="overflow:%20clip;%20width:%20100px;%20height:%20100px">%20%20%20<rect%20width="200"%20height="200"%20fill="green">%20</svg>



while it is working for simple divs.
data:text/html,<div%20style="overflow:clip;width:100px;height:100px"><div%20style="width:200px;height:200px;background-color:gold"></div></div>

Work in Firefox and Chrome.
Comment 1 Radar WebKit Bug Importer 2022-09-02 01:52:37 PDT 
<rdar://problem/99479553>
Comment 2 Rob Buis 2022-09-07 03:04:05 PDT 
Created attachment 462177 [details]
Patch
Comment 3 Simon Fraser (smfr) 2022-09-07 10:39:19 PDT 
Comment on attachment 462177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462177&action=review

> Source/WebCore/rendering/svg/LegacyRenderSVGRoot.cpp:216
> +    return effectiveOverflowX() == Overflow::Hidden || style().overflowX() == Overflow::Auto

Would be nice to have a isNonVisibleOverflow(Overflow) helper we can use everywhere.
Comment 4 Rob Buis 2022-09-08 01:17:25 PDT 
Created attachment 462199 [details]
Patch
Comment 5 Simon Fraser (smfr) 2022-09-08 13:06:51 PDT 
Comment on attachment 462199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=462199&action=review

> Source/WebCore/rendering/style/RenderStyle.h:2553
> +inline bool isNonVisibleOverflow(const Overflow& overflow)

Overflow is a uint8_t enum, so it's more efficient to pass by value.
Comment 6 Rob Buis 2022-09-09 01:03:39 PDT 
Created attachment 462221 [details]
Patch
Comment 7 EWS 2022-09-09 02:54:59 PDT 
Committed 254295@main (88bf94fa06f3): <https://commits.webkit.org/254295@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 462221 [details].