Bug 244693

Summary:	REGRESSION (253726@main): [ macOS wk1 Debug ] ASSERTION FAILED: !needsLayout() page/FrameView.cpp(4560) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	hi, ryanhaddad, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=244714 https://bugs.webkit.org/show_bug.cgi?id=244696 https://bugs.webkit.org/show_bug.cgi?id=244676

Description Karl Rackler 2022-09-01 16:10:01 PDT

Description:
media/video-element-other-namespace-crash.html is a flaky crash

This test was consistently passing until at 253726@main it began to flaky crash.

REPRODUCTION STEPS
I can reproduce this on 253726@main but cannot reproduce it on 253725@main or earlier.

Command: 
run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry media/video-element-other-namespace-crash.html

Result: 
Unexpected flakiness: crashes (1)
  media/video-element-other-namespace-crash.html [ Crash Pass ]

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-element-other-namespace-crash.html&platform=mac&style=debug&flavor=wk1

Crash Log:
No crash log found for DumpRenderTree:52484.

stdout:

stderr:
2022-09-01 11:22:00.735 DumpRenderTree[52484:19425633] nil host used in call to allowsSpecificHTTPSCertificateForHost
2022-09-01 11:22:00.735 DumpRenderTree[52484:19425633] nil host used in call to allowsAnyHTTPSCertificateForHost:
2022-09-01 11:22:00.882 DumpRenderTree[52484:19425633] nil host used in call to allowsSpecificHTTPSCertificateForHost
2022-09-01 11:22:00.883 DumpRenderTree[52484:19425633] nil host used in call to allowsAnyHTTPSCertificateForHost:
ASSERTION FAILED: !needsLayout()
page/FrameView.cpp(4560) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext *)
1   0x11f443069 WTFCrash
2   0x12ee14efb WTFCrashWithInfo(int, char const*, char const*, int)
3   0x1336454ef WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
4   0x10540aa1c -[WebFrame(WebInternal) _drawRect:contentsOnly:]
5   0x10542e9d3 -[WebHTMLView drawSingleRect:]
6   0x10542f035 -[WebHTMLView drawRect:]
7   0x7ff80bec3280 _NSViewDrawRect
8   0x7ff80c5de3bd -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
9   0x1054227c6 -[WebHTMLView(WebPrivate) _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
10  0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
11  0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
12  0x7ff80c5de70b -[NSView _recursive:displayRectIgnoringOpacity:inContext:stopAtLayerBackedViews:]
13  0x7ff80c033195 -[NSView displayRectIgnoringOpacity:inContext:]
14  0x13150dd2c WebCore::Widget::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
15  0x133901023 WebCore::ScrollView::paint(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy, WebCore::EventRegionContext*)
16  0x13442eb99 WebCore::RenderWidget::paintContents(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
17  0x13442f453 WebCore::RenderWidget::paint(WebCore::PaintInfo&, WebCore::LayoutPoint const&)
18  0x1342bf246 WebCore::RenderLayer::paintForegroundForFragmentsWithPhase(WebCore::PaintPhase, WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
19  0x1342bcfbd WebCore::RenderLayer::paintForegroundForFragments(WTF::Vector<WebCore::LayerFragment, 1ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::GraphicsContext&, WebCore::GraphicsContext&, WebCore::LayoutRect const&, bool, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::RenderObject*)
20  0x1342b9278 WebCore::RenderLayer::paintLayerContents(WebCore::GraphicsContext&, WebCore::RenderLayer::LayerPaintingInfo const&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>)
21  0x1343034e2 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)::$_11::operator()(WebCore::RenderLayer&, WTF::OptionSet<WebCore::RenderLayer::PaintLayerFlag>) const
22  0x134302e06 WebCore::RenderLayerBacking::paintIntoLayer(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::IntRect const&, WTF::OptionSet<WebCore::PaintBehavior>, WebCore::EventRegionContext*)
23  0x134304241 WebCore::RenderLayerBacking::paintContents(WebCore::GraphicsLayer const*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
24  0x133b2c4f0 WebCore::GraphicsLayer::paintGraphicsLayerContents(WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
25  0x133c12a7f WebCore::GraphicsLayerCA::platformCALayerPaintContents(WebCore::PlatformCALayer*, WebCore::GraphicsContext&, WebCore::FloatRect const&, unsigned int)
26  0x13112e700 WebCore::PlatformCALayer::drawLayerContents(WebCore::GraphicsContext&, WebCore::PlatformCALayer*, WTF::Vector<WebCore::FloatRect, 5ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc>&, unsigned int)
27  0x131239696 -[WebLayer drawInContext:]
28  0x7ff8103f199d CABackingStoreUpdate_
29  0x7ff8104559fd invocation function for block in CA::Layer::display_()
30  0x7ff8103f09d1 -[CALayer _display]
31  0x131239fad -[WebSimpleLayer display]

Comment 1 Radar WebKit Bug Importer 2022-09-01 16:10:18 PDT

<rdar://problem/99462545>

Comment 2 Karl Rackler 2022-09-01 16:14:52 PDT

I have marked this test as a flaky crash while this issue is investigated.

Comment 3 EWS 2022-09-01 16:22:09 PDT

Test gardening commit 254077@main (d3c637a1f571): <https://commits.webkit.org/254077@main>

Reviewed commits have been landed. Closing PR #3937 and removing active labels.

Comment 4 Alexey Proskuryakov 2022-09-04 12:30:17 PDT

I don't think that we need all these separate bugs for this regression. We should just revert (and remove expectations, of course).

Comment 5 Karl Rackler 2022-09-07 05:56:58 PDT

Skipping test affected by wk1 debug only assertion caused by an underlying issue.
https://github.com/WebKit/WebKit/pull/4093