Bug 244640

Summary:	run_benchmark.py:84: SyntaxWarning: "is not" with a literal. Did you mean "!="?
Product:	WebKit	Reporter:	David Kilzer (:ddkilzer) <ddkilzer>
Component:	Tools / Tests	Assignee:	David Kilzer (:ddkilzer) <ddkilzer>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	dewei_zhu, jbedard, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	239313
Bug Blocks:

David Kilzer (:ddkilzer)

Reported 2022-08-31 16:41:17 PDT

Checking imports ...Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:84: SyntaxWarning: "is not" with a literal. Did you mean "!="? if args.generate_profiles and args.platform is not 'osx':

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2022-08-31 16:43:22 PDT

<rdar://problem/99410243>

David Kilzer (:ddkilzer)

Comment 2 2022-08-31 16:43:53 PDT

Seen when running `Tools/Scripts/test-webkitpy`.

David Kilzer (:ddkilzer)

Comment 3 2022-08-31 16:45:18 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3885

David Kilzer (:ddkilzer)

Comment 4 2022-08-31 16:49:12 PDT

Regressed commit b820e2b4bab7 for Bug 239313.

EWS

Comment 5 2022-08-31 21:07:15 PDT

Committed 254028@main (df1637717d1d): <https://commits.webkit.org/254028@main> Reviewed commits have been landed. Closing PR #3885 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.