Bug 244636

Summary: REGRESSION (221259@main?): [ Monterey wk1 Debug ] media/modern-media-controls/pip-support/pip-support-click.html is a flaky crash
Product: WebKit Reporter: Karl Rackler <rackler>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, graouts, jer.noble, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
symbolicated-log none

Description Karl Rackler 2022-08-31 15:07:28 PDT 
Description:
media/modern-media-controls/pip-support/pip-support-click.html

The test was added at 182031@main.  The last modification to the test was at 221259@main.  The first failure I saw on the viewable dashboard was at 243892@main, and the test has been a flaky crash since.

REPRODUCTION STEPS
I can reproduce this on <commit> but cannot reproduce it on <commit> or earlier.

Command: 
run-webkit-tests --debug --root 254006@main-debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry media/modern-media-controls/pip-support/pip-support-click.html

Result: 
Regressions: Unexpected crashes (1)
  media/modern-media-controls/pip-support/pip-support-click.html [ Crash ]

History:
https://results.webkit.org/?suite=layout-tests&test=media%2Fmodern-media-controls%2Fpip-support%2Fpip-support-click.html&platform=mac&flavor=wk1&style=debug&version_name=Monterey&limit=50000&recent=false

Crash Log:
Thread 0 Crashed::   Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	       0x11f7a072e    WTFCrash
1   com.apple.JavaScriptCore      	       0x11f7c1b82    ReportBlockedObjCException(NSException*)
2   com.apple.WebKitLegacy        	       0x10d14a43c    WebChromeClient::enterVideoFullscreenForVideoElement(WebCore::HTMLVideoElement&, unsigned int, bool)
3   com.apple.WebCore             	       0x12ba43796    WebCore::HTMLMediaElement::enterFullscreen(unsigned int)::$_42::operator()() const
4   com.apple.WebCore             	       0x12ba43558    WTF::Detail::CallableWrapper<WebCore::HTMLMediaElement::enterFullscreen(unsigned int)::$_42, void>::call()
5   com.apple.WebCore             	       0x12803e962    WTF::Function<void ()>::operator()() const
6   com.apple.WebCore             	       0x12ba1f0e8    void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::HTMLMediaElement>(WebCore::HTMLMediaElement&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'()::operator()() const
7   com.apple.WebCore             	       0x12ba1ee38    WTF::Detail::CallableWrapper<void WebCore::ActiveDOMObject::queueTaskKeepingObjectAlive<WebCore::HTMLMediaElement>(WebCore::HTMLMediaElement&, WebCore::TaskSource, WTF::Function<void ()>&&)::'lambda'(), void>::call()
8   com.apple.WebCore             	       0x12803e962    WTF::Function<void ()>::operator()() const
9   com.apple.WebCore             	       0x12b5f9c58    WebCore::EventLoopFunctionDispatchTask::execute()
10  com.apple.WebCore             	       0x12b5ec370    WebCore::EventLoop::run()
Comment 1 Radar WebKit Bug Importer 2022-08-31 15:07:48 PDT 
<rdar://problem/99405701>
Comment 2 Karl Rackler 2022-08-31 15:12:09 PDT 
[ Edit ] 
REPRODUCTION STEPS
I can reproduce this on 254006@main ToT.
Comment 3 Karl Rackler 2022-08-31 15:20:28 PDT 
I have marked this test as a flaky crash while this issue is investigated.
Comment 4 EWS 2022-08-31 15:32:14 PDT 
Test gardening commit 254012@main (44e0bb9d02dc): <https://commits.webkit.org/254012@main>

Reviewed commits have been landed. Closing PR #3882 and removing active labels.
Comment 5 Karl Rackler 2022-08-31 15:48:02 PDT 
Created attachment 462060 [details]
symbolicated-log
Comment 6 Ryan Haddad 2023-01-04 08:57:39 PST 
I think this was fixed by. https://commits.webkit.org/258013@main, there haven't been crashes since then. Will remove test expectations.