| Summary: | [GLib] Deprecate WebKitSettings enable-frame-flattening | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> |
| Component: | WebKitGTK | Assignee: | Michael Catanzaro <mcatanzaro> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | bugs-noreply, mcatanzaro, yaneti, zalan |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=242883 | ||
|
Description
Michael Catanzaro
2022-08-31 12:22:51 PDT
We cannot remove the underlying preference from WebPreferences.yaml and WebPreferencesInternal.yaml because it still supports public API in WebKitLegacy/mac/WebView/WebPreferences.mm and WebKitLegacy/mac/WebView/WebView.mm. Pull request: https://github.com/WebKit/WebKit/pull/3876 Committed 254014@main (1978c2756325): <https://commits.webkit.org/254014@main> Reviewed commits have been landed. Closing PR #3876 and removing active labels. I am not sure I understand the logic here. It marks as deprecated which is OK, but also turns the setting in a noop default to false ? Which would not help evolution which explicitly sets it to true to actually use the now deprecated code Maybe my code comprehension is failing me.. That's the patch for the main branch. For the 2.38 branch, I instead committed exactly the patch that you uploaded on Red Hat Bugzilla: https://github.com/WebKit/WebKit/commit/871eeae26321fc4d5f6769887f2aae42200b5a6e And a different deprecation that keeps the setting alive: https://github.com/WebKit/WebKit/commit/a94dc7e25c83a375fd9ac3e73f56c2794336b176 Ah, thanks, I missed the branch difference. Sorry for the noise |