Bug 244611

Summary:	Test addition (248077@main): [ macOS wk1 Debug ] http/tests/loading/form-submission-no-load-event.html is a flaky crash
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Karl Rackler 2022-08-31 09:31:41 PDT

Description:
http/tests/loading/form-submission-no-load-event.html

This test was added at 248077@main and has been a flaky crash since.

REPRODUCTION STEPS
I can reproduce this on 253982@main ToT.

Command: 
run-webkit-tests --debug -1 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 -f --no-retry http/tests/loading/form-submission-no-load-event.html

Result: 
Unexpected flakiness: crashes (1)
  http/tests/loading/form-submission-no-load-event.html [ Crash Pass ]

History:
https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Floading%2Fform-submission-no-load-event.html&platform=mac&flavor=wk1&style=debug&limit=50000

Crash Log:
No crash log found for DumpRenderTree:12528.

stdout:
main frame - didStartProvisionalLoadForFrame
main frame - didCommitLoadForFrame
main frame - willPerformClientRedirectToURL: about:blank?input=
main frame - didFinishDocumentLoadForFrame
main frame - didHandleOnloadEventsForFrame
main frame - didFinishLoadForFrame
Tests that the load event fires if a form submission to a new window happens during the load.

PASS: The load event was fired


stderr:
ASSERTION FAILED: gTestRunner->waitToDump()
/Volumes/Data/worker/Apple-Monterey-Debug-Build/build/Tools/DumpRenderTree/mac/UIDelegate.mm(179) : -[UIDelegate webView:createWebViewWithRequest:]
1   0x11f30b729 WTFCrash
2   0x100594a7b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x10068986b -[UIDelegate webView:createWebViewWithRequest:]
4   0x101b34635 -[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]
5   0x7ff8093262bc __invoking___
6   0x7ff809326163 -[NSInvocation invoke]
7   0x7ff809355cdb -[NSInvocation invokeWithTarget:]
8   0x101acbb52 -[_WebSafeForwarder forwardInvocation:]
9   0x7ff809324b98 ___forwarding___
10  0x7ff809324818 _CF_forwarding_prep_0
11  0x101a3725b WebFrameLoaderClient::dispatchCreatePage(WebCore::NavigationAction const&, WebCore::NewFrameOpenerPolicy)
12  0x1332387b9 WebCore::FrameLoader::continueLoadAfterNewWindowPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck, WebCore::AllowNavigationToInvalidURL, WebCore::NewFrameOpenerPolicy)
13  0x1332508d4 WebCore::FrameLoader::loadURL(WebCore::FrameLoadRequest&&, WTF::String const&, WebCore::FrameLoadType, WebCore::Event*, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, std::__1::optional<WebCore::PrivateClickMeasurement>&&, WTF::CompletionHandler<void ()>&&)::$_3::operator()(WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)
14  0x13325074e WTF::Detail::CallableWrapper<WebCore::FrameLoader::loadURL(WebCore::FrameLoadRequest&&, WTF::String const&, WebCore::FrameLoadType, WebCore::Event*, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, std::__1::optional<WebCore::PrivateClickMeasurement>&&, WTF::CompletionHandler<void ()>&&)::$_3, void, WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck>::call(WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)
15  0x1332ad077 WTF::Function<void (WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)>::operator()(WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck) const
16  0x13328706d WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)>::operator()(WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)
17  0x1332ad8d2 WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy(WebCore::NavigationAction&&, WebCore::ResourceRequest&&, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, WTF::AtomString const&, WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)>&&)::$_9::operator()(WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >)
18  0x1332ad476 WTF::Detail::CallableWrapper<WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy(WebCore::NavigationAction&&, WebCore::ResourceRequest&&, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, WTF::AtomString const&, WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)>&&)::$_9, void, WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> > >::call(WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >)
19  0x101a4108b WTF::Function<void (WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >)>::operator()(WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >) const
20  0x101a41344 -[WebFramePolicyListener receivedPolicyDecision:]
21  0x101a41523 -[WebFramePolicyListener use]
22  0x101b34415 -[WebDefaultPolicyDelegate webView:decidePolicyForNewWindowAction:request:newFrameName:decisionListener:]
23  0x7ff8093262bc __invoking___
24  0x7ff809326163 -[NSInvocation invoke]
25  0x7ff809355cdb -[NSInvocation invokeWithTarget:]
26  0x101acba81 -[_WebSafeForwarder forwardInvocation:]
27  0x7ff809324b98 ___forwarding___
28  0x7ff809324818 _CF_forwarding_prep_0
29  0x101a37a52 WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction(WebCore::NavigationAction const&, WebCore::ResourceRequest const&, WebCore::FormState*, WTF::String const&, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >, WTF::Function<void (WebCore::PolicyAction, WebCore::ProcessQualified<WTF::ObjectIdentifier<WebCore::LocalPolicyCheckIdentifierType> >)>&&)
30  0x133286edd WebCore::FrameLoader::PolicyChecker::checkNewWindowPolicy(WebCore::NavigationAction&&, WebCore::ResourceRequest&&, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, WTF::AtomString const&, WTF::CompletionHandler<void (WebCore::ResourceRequest const&, WTF::WeakPtr<WebCore::FormState, WTF::EmptyCounter>&&, WTF::AtomString const&, WebCore::NavigationAction const&, WebCore::ShouldContinuePolicyCheck)>&&)
31  0x13322700f WebCore::FrameLoader::loadURL(WebCore::FrameLoadRequest&&, WTF::String const&, WebCore::FrameLoadType, WebCore::Event*, WTF::RefPtr<WebCore::FormState, WTF::RawPtrTraits<WebCore::FormState>, WTF::DefaultRefDerefTraits<WebCore::FormState> >&&, std::__1::optional<WebCore::PrivateClickMeasurement>&&, WTF::CompletionHandler<void ()>&&)

Comment 1 Radar WebKit Bug Importer 2022-08-31 09:32:53 PDT

<rdar://problem/99386658>

Comment 2 Karl Rackler 2022-08-31 09:35:23 PDT

I have marked this test as a flaky crash while this issue is investigated.

Comment 3 EWS 2022-08-31 09:45:25 PDT

Test gardening commit 253990@main (6f830cd1bb71): <https://commits.webkit.org/253990@main>

Reviewed commits have been landed. Closing PR #3856 and removing active labels.

Comment 4 Chris Dumez 2022-08-31 14:01:21 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3875

Comment 5 EWS 2022-09-02 10:56:18 PDT

Committed 254105@main (ccb35d4fd9ec): <https://commits.webkit.org/254105@main>

Reviewed commits have been landed. Closing PR #3875 and removing active labels.