Bug 244515

Summary: REBASELINE(253816@main): [ iOS GTK Win ] svg/foreignObject/fO-parent-display-changes.svg is a constant failure
Product: WebKit Reporter: Hercules Hjalmarsson <hhjalmarsson>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sabouhallawa, webkit-bot-watchers-bugzilla, webkit-bug-importer, zimmermann
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Hercules Hjalmarsson 2022-08-29 15:05:29 PDT
svg/foreignObject/fO-parent-display-changes.svg

Is a constant text failure on iOS ToT and since 253816@main. Judging by 253816@main it appears that the re-baseline was only done for macOS which causes iOS tests to fail.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=svg/foreignObject/fO-parent-display-changes.svg

DIFF:
@@ -1,11 +1,11 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
 layer at (0,0) size 800x600
-  RenderSVGRoot {svg} at (0,0) size 100x90
-    RenderSVGContainer {g} at (0,0) size 0x0
-      RenderSVGForeignObject {foreignObject} at (0,0) size 0x0
-        RenderBlock {html} at (0,0) size 0x100
+  RenderSVGRoot {svg} at (0,0) size 100x100
     RenderSVGRect {rect} at (0,0) size 100x90 [fill={[type=SOLID] [color=#008000]}] [x=0.00] [y=0.00] [width=100.00] [height=90.00]
+    RenderSVGContainer {g} at (0,0) size 100x100
+      RenderSVGForeignObject {foreignObject} at (0,0) size 100x100
+        RenderBlock {html} at (0,0) size 100x100
 layer at (0,0) size 100x100
   RenderBody {body} at (0,0) size 100x100 [color=#FFFFFF]
     RenderText {#text} at (0,0) size 37x19

DIFF URL:
https://build.webkit.org/results/Apple-iOS-15-Simulator-Debug-WK2-Tests/253816@main%20(3498)/svg/foreignObject/fO-parent-display-changes-pretty-diff.html
Comment 1 Radar WebKit Bug Importer 2022-08-29 15:05:49 PDT
<rdar://problem/99297904>
Comment 2 Hercules Hjalmarsson 2022-08-29 15:06:58 PDT
This issue can be bisected to 253816@main using command:

run-webkit-tests --debug --ios-simulator --iterations=2 svg/foreignObject/fO-parent-display-changes.svg
Comment 3 Nikolas Zimmermann 2022-08-30 04:05:53 PDT
Thanks for taking care - indeed a rebaseline is needed!
Comment 4 EWS 2022-08-30 10:34:19 PDT
Test gardening commit 253951@main (d738c248e134): <https://commits.webkit.org/253951@main>

Reviewed commits have been landed. Closing PR #3816 and removing active labels.