Bug 244434

Summary: [IFC][Integration] Do not paint ellipsis on non-visible block boxes.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[fast-cq]Patch none

alan
Reported 2022-08-27 10:57:19 PDT
ssia
Attachments
[fast-cq]Patch (1.35 KB, patch)
2022-08-27 10:58 PDT, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-08-27 10:58:44 PDT
Created attachment 461927 [details] [fast-cq]Patch
Antti Koivisto
Comment 2 2022-08-28 09:46:13 PDT
Comment on attachment 461927 [details] [fast-cq]Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461927&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:105 > + if (m_paintInfo.phase != PaintPhase::Foreground || root().style().visibility() != Visibility::Visible) We should probably support some other PaintPhases (at least TextClip, not sure about the others)
alan
Comment 3 2022-08-28 16:33:29 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 461927 [details] > [fast-cq]Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461927&action=review > > > Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:105 > > + if (m_paintInfo.phase != PaintPhase::Foreground || root().style().visibility() != Visibility::Visible) > > We should probably support some other PaintPhases (at least TextClip, not > sure about the others) yeah
EWS
Comment 4 2022-08-28 16:35:57 PDT
Committed 253888@main (682b15d4271a): <https://commits.webkit.org/253888@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461927 [details].
Radar WebKit Bug Importer
Comment 5 2022-08-28 16:36:16 PDT
<rdar://problem/99255856>
Note You need to log in before you can comment on or make changes to this bug.