Bug 244364
| Summary: | [AppSSO] Adjust life cycle of SOAuthorization to avoid premature cancellation | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | kkinnunen |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Brent Fulgham
Testing has shown that attempting to share a single SOAuthorization object amongst several active sessions can lead to deadlocks during AppSSO authentication.
Since the SOAuthorization object is meant to be stateless, there is no harm in constructing and destroying it for each type of authentication flow.
This simplifies the logic, and makes it clear which SOAuthorization object is associated with a given load event.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Brent Fulgham
<rdar://98413693>
Brent Fulgham
Pull request: https://github.com/Webkit/WebKit/pull/3684
EWS
Committed 253929@main (bc90c50c6ba8): <https://commits.webkit.org/253929@main>
Reviewed commits have been landed. Closing PR #3684 and removing active labels.