| Summary: | [IFC][Integration] Introduce InlineContentPainter | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2022-08-25 10:20:02 PDT
Created attachment 461860 [details]
Patch
Comment on attachment 461860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461860&action=review nice! > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765 > -class LayerPaintScope { LineLayout::hitTest uses this. If this compiles it must be by accident. > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771 > + if (!m_inlineContent) Maybe we could eliminate these tests at some point, they shouldn't really happen Created attachment 461869 [details]
Patch
Committed 253801@main (1ab9ad2f5f0d): <https://commits.webkit.org/253801@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461869 [details]. (In reply to Antti Koivisto from comment #2) > Comment on attachment 461860 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461860&action=review > > nice! > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765 > > -class LayerPaintScope { > > LineLayout::hitTest uses this. If this compiles it must be by accident. > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771 > > + if (!m_inlineContent) > > Maybe we could eliminate these tests at some point, they shouldn't really > happen yes, please! |