Bug 244339

Summary: [IFC][Integration] Introduce InlineContentPainter
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2022-08-25 10:20:02 PDT
to paint IFC inline content
Attachments
Patch (24.58 KB, patch)
2022-08-25 10:21 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (24.60 KB, patch)
2022-08-25 15:16 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2022-08-25 10:21:37 PDT
Created attachment 461860 [details] Patch
Antti Koivisto
Comment 2 2022-08-25 12:57:34 PDT
Comment on attachment 461860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461860&action=review nice! > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765 > -class LayerPaintScope { LineLayout::hitTest uses this. If this compiles it must be by accident. > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771 > + if (!m_inlineContent) Maybe we could eliminate these tests at some point, they shouldn't really happen
alan
Comment 3 2022-08-25 15:16:42 PDT
Created attachment 461869 [details] Patch
EWS
Comment 4 2022-08-25 18:11:10 PDT
Committed 253801@main (1ab9ad2f5f0d): <https://commits.webkit.org/253801@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461869 [details].
Radar WebKit Bug Importer
Comment 5 2022-08-25 18:12:16 PDT
<rdar://problem/99164823>
alan
Comment 6 2022-08-25 18:45:39 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 461860 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461860&action=review > > nice! > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:-765 > > -class LayerPaintScope { > > LineLayout::hitTest uses this. If this compiles it must be by accident. > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:771 > > + if (!m_inlineContent) > > Maybe we could eliminate these tests at some point, they shouldn't really > happen yes, please!
Note You need to log in before you can comment on or make changes to this bug.