Bug 244286

Summary:	-webkit-line-clamp should not clamp each flex item individually
Product:	WebKit	Reporter:	Karl Dubost <karlcow>
Component:	CSS	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED CONFIGURATION CHANGED
Severity:	Normal	CC:	ahmad.saleem792, calum.p.m.smith, emilio, webkit-bug-importer, woodlxf00
Priority:	P2	Keywords:	BrowserCompat, InRadar
Version:	Safari Technology Preview
Hardware:	Unspecified
OS:	Unspecified
URL:	https://bug1786147.bmoattachments.org/attachment.cgi?id=9290798
Bug Depends on:
Bug Blocks:	233770

Description Karl Dubost 2022-08-23 22:58:09 PDT

Mozilla Test Case: https://bug1786147.bmoattachments.org/attachment.cgi?id=9290798

This is working on Blink, but fails in Gecko and WebKit.

Blink does something differently, see Emilio's comment on Mozilla Bugzilla
https://bugzilla.mozilla.org/show_bug.cgi?id=1786147#c3

> It seems Blink now special-cases "old flex box with line-clamp" and just creates a single block: 
> https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/layout/layout_object.cc;l=356;drc=312b74e385e6aba98ab31fd911238c0dc16b396c

This was added in Blink with this commit.
https://github.com/chromium/chromium/commit/383112a


This creates webcompat issues
see https://github.com/webcompat/web-bugs/issues/109468
and https://github.com/webcompat/web-bugs/issues/107595

Emilio is in the process of creating a patch to match Chrome's behavior.

But I wonder if this should also be discussed on the spec side. 
It also probably needs a simplified test case.

Comment 1 Radar WebKit Bug Importer 2022-08-23 23:58:18 PDT

<rdar://problem/99070494>

Comment 2 Karl Dubost 2022-09-28 01:21:02 PDT

*** Bug 245459 has been marked as a duplicate of this bug. ***

Comment 3 Ahmad Saleem 2023-05-20 04:19:22 PDT

WebKit ToT (264288@main) & Safari Technology Preview 170 are matching with Chrome Canary 115 & Firefox Nightly 115.

Since all browsers are matching, I am marking this as "RESOLVED CONFIGURATION CHANGED", if it still exist, please reopen.

Comment 4 Woody Lee 2024-02-29 01:46:02 PST

Note: it was resolved at 263360@main in https://bugs.webkit.org/show_bug.cgi?id=255487