| Summary: | [IFC][Integration] Implement selectionState for ellipsis box | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2022-08-22 16:26:34 PDT
Created attachment 461810 [details]
Patch
Created attachment 461821 [details]
Patch
Comment on attachment 461821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461821&action=review > Source/WebCore/rendering/EllipsisBoxPainter.cpp:140 > + auto pathCopy = m_ellipsisBox; > + return InlineIterator::LeafBoxIterator { WTFMove(pathCopy) }->selectionState(); Why this dance? Comment on attachment 461821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461821&action=review > Source/WebCore/rendering/EllipsisBoxPainter.cpp:48 > +EllipsisBoxPainter<EllipsisBoxPath>::EllipsisBoxPainter(EllipsisBoxPath&& ellipsisBox, PaintInfo& paintInfo, const LayoutPoint& paintOffset, Color selectionForegroundColor, Color selectionBackgroundColor) We can probably undo the templating at some point and just use the iterator, I think it is an over-optimization. Created attachment 461823 [details]
Patch
(In reply to Antti Koivisto from comment #4) > Comment on attachment 461821 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461821&action=review > > > Source/WebCore/rendering/EllipsisBoxPainter.cpp:48 > > +EllipsisBoxPainter<EllipsisBoxPath>::EllipsisBoxPainter(EllipsisBoxPath&& ellipsisBox, PaintInfo& paintInfo, const LayoutPoint& paintOffset, Color selectionForegroundColor, Color selectionBackgroundColor) > > We can probably undo the templating at some point and just use the iterator, > I think it is an over-optimization. Agree! Committed 253714@main (a3119d12cba0): <https://commits.webkit.org/253714@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461823 [details]. |