Bug 244217

Summary: REGRESSION (253623@main): 14 test262 tests are is a consistent failure
Product: WebKit Reporter: Karl Rackler <rackler>
Component: JavaScriptCoreAssignee: Ross Kirsling <ross.kirsling>
Status: RESOLVED FIXED    
Severity: Normal CC: ross.kirsling, webkit-bot-watchers-bugzilla, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Karl Rackler 2022-08-22 13:29:42 PDT
These tests first fail on the build https://build.webkit.org/#/builders/364/builds/7317 with a change at https://commits.webkit.org/253623@main.

https://build.webkit.org/#/builders/364/builds/7317/steps/12/logs/stdio
---------------NEW FAILING TESTS SUMMARY---------------

FAIL test/harness/temporalHelpers-one-shift-time-zone.js (default)
Full Output:
Exception: TypeError: realTz.getOffsetNanosecondsFor is not a function. (In 'realTz.getOffsetNanosecondsFor(shiftInstant)', 'realTz.getOffsetNanosecondsFor' is undefined)
checkTimeZoneArithmetic@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/harness/temporalHelpers-one-shift-time-zone.js:23:35
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/harness/temporalHelpers-one-shift-time-zone.js:59:24

FAIL test/harness/temporalHelpers-one-shift-time-zone.js (strict mode)
Full Output:
Exception: TypeError: realTz.getOffsetNanosecondsFor is not a function. (In 'realTz.getOffsetNanosecondsFor(shiftInstant)', 'realTz.getOffsetNanosecondsFor' is undefined)
checkTimeZoneArithmetic@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/harness/temporalHelpers-one-shift-time-zone.js:24:35
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/harness/temporalHelpers-one-shift-time-zone.js:60:24

FAIL test/intl402/DateTimeFormat/prototype/format/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/format/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:13:44

FAIL test/intl402/DateTimeFormat/prototype/format/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/format/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:14:44

FAIL test/intl402/DateTimeFormat/prototype/formatRange/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatRange/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:15:45

FAIL test/intl402/DateTimeFormat/prototype/formatRange/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatRange/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:16:45

FAIL test/intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:15:45

FAIL test/intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatRangeToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:16:45

FAIL test/intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:13:44

FAIL test/intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(8, 4)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/DateTimeFormat/prototype/formatToParts/temporal-objects-timezone-getoffsetnanosecondsfor-not-callable.js:14:44

FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js:17:44

FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js:18:44

FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js:17:44

FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js:18:44

---------------------------------------------------------
14 tests newly fail
Comment 1 Radar WebKit Bug Importer 2022-08-22 13:30:06 PDT
<rdar://problem/98996726>
Comment 2 Ross Kirsling 2022-08-22 13:40:40 PDT
Ah, these are just updated error messages for existing failures. I can land a gardening update though.
Comment 3 Karl Rackler 2022-08-22 13:42:57 PDT
(In reply to Ross Kirsling from comment #2)
> Ah, these are just updated error messages for existing failures. I can land
> a gardening update though.

Thank you!
Comment 4 Ross Kirsling 2022-08-22 13:50:39 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3549
Comment 5 EWS 2022-08-22 13:53:01 PDT
Committed 253657@main (44dbaced8326): <https://commits.webkit.org/253657@main>

Reviewed commits have been landed. Closing PR #3549 and removing active labels.
Comment 6 Karl Rackler 2022-08-22 16:01:57 PDT
(In reply to Ross Kirsling from comment #4)
> Pull request: https://github.com/WebKit/WebKit/pull/3549

Thank you Ross!

After landing https://commits.webkit.org/253657@main there are four remaining failures.  I appreciate your assistance.

---------------NEW FAILING TESTS SUMMARY---------------
FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js:17:44
FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js:18:44
FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js (default)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js:17:44
FAIL test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js (strict mode)
Full Output:
Exception: TypeError: undefined is not a constructor (evaluating 'new Temporal.PlainMonthDay(5, 2)')
global code@/Volumes/Data/worker/Apple-Monterey-Debug-Test262-Tests/build/JSTests/test262/test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js:18:44
---------------------------------------------------------
4 tests newly fail
Comment 7 Karl Rackler 2022-08-22 16:02:38 PDT
Reopened for four remaining failures.
Comment 8 Ross Kirsling 2022-08-22 16:03:33 PDT
Argh. Didn't notice that the directory differed for those.
Comment 10 Karl Rackler 2022-08-23 09:10:36 PDT
(In reply to Ross Kirsling from comment #9)
> Committed 253661@main (fa71931): https://commits.webkit.org/253661@main
> 
> (https://github.com/WebKit/WebKit/pull/3556)

Thank you Ross.  Verified all tests consistently passing after landing 253657@main & 253661@main.