Bug 244184

Summary:	[GLIB] aptIfExists always returns exit status code 0
Product:	WebKit	Reporter:	Diego Pino <dpino>
Component:	New Bugs	Assignee:	Diego Pino <dpino>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	bugs-noreply, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Diego Pino

Reported 2022-08-22 01:55:03 PDT

Reported by Andrew Sutherland at https://github.com/WebKit/WebKit/pull/1323#discussion_r950626647 Function `aptIfExists` from script `Tools/glib/dependencies/atk` always return exist status code 0 since in Bash a declaration of variable that is inmediately assigned is always successful. This error makes the script `Tools/gtk/install-depedencies` fail in systems that cannot provide a package wrapped in `aptIfExists` statement.

Attachments
Add attachment proposed patch, testcase, etc.

Diego Pino

Comment 1 2022-08-22 01:56:59 PDT

Pull request: https://github.com/webkit/webkit/pull/3525

EWS

Comment 2 2022-08-22 06:26:07 PDT

Committed 253643@main (0c682bc2aaaa): <https://commits.webkit.org/253643@main> Reviewed commits have been landed. Closing PR #3525 and removing active labels.

Radar WebKit Bug Importer

Comment 3 2022-08-22 06:27:15 PDT

<rdar://problem/98978365>

Note You need to log in before you can comment on or make changes to this bug.