| Summary: | [LFC][IFC] text-overflow: ellipsis should not affect geometries | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2022-08-21 15:35:41 PDT
Created attachment 461780 [details]
Patch
Comment on attachment 461780 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461780&action=review > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872 > + if (!hasDamage(box)) > + continue; Maybe the hasDamage(box) test could go before all the type tests too and be done in one place only. Not sure about the inline-block case... (In reply to Antti Koivisto from comment #2) > Comment on attachment 461780 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=461780&action=review > > > Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:872 > > + if (!hasDamage(box)) > > + continue; > > Maybe the hasDamage(box) test could go before all the type tests too and be > done in one place only. Not sure about the inline-block case... good point. will do in a followup patch. Committed 253650@main (dfaf8254ed07): <https://commits.webkit.org/253650@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461780 [details]. |