Bug 244089

Summary:	REGRESSION(253530@main): [ iOS macOS ] TestWebKitAPI.DocumentOrder.Positions is a constant crash
Product:	WebKit	Reporter:	Hercules Hjalmarsson <hhjalmarsson>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Hercules Hjalmarsson 2022-08-18 08:55:36 PDT

TestWebKitAPI.DocumentOrder.Positions

Is a constant API crash on ToT and since 253530@main.

HISTORY:
https://results.webkit.org/?suite=api-tests&test=TestWebKitAPI.DocumentOrder.Positions

DIFF:
ASSERTION FAILED: m_isConstructed
        /Volumes/Data/worker/Apple-Monterey-Debug-Build/build/WebKitBuild/Debug/usr/local/include/wtf/NeverDestroyed.h(152) : WTF::LazyNeverDestroyed::PointerType WTF::LazyNeverDestroyed<const WebCore::QualifiedName>::storagePointerWithoutAccessCheck() const [T = const WebCore::QualifiedName, AccessTraits = WTF::AnyThreadsAccessTraits]
        1   0x122ac30c9 WTFCrash
        2   0x12bb3287b WTFCrashWithInfo(int, char const*, char const*, int)
        3   0x12be53ed7 WTF::LazyNeverDestroyed<WebCore::QualifiedName const, WTF::AnyThreadsAccessTraits>::storagePointerWithoutAccessCheck() const
        4   0x12be53e62 WTF::LazyNeverDestroyed<WebCore::QualifiedName const, WTF::AnyThreadsAccessTraits>::storagePointer() const
        5   0x12be3ec55 WTF::LazyNeverDestroyed<WebCore::QualifiedName const, WTF::AnyThreadsAccessTraits>::operator WebCore::QualifiedName const&()
        6   0x12f4577c3 WebCore::Element::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason)
        7   0x12f5ff6d0 WebCore::StyledElement::attributeChanged(WebCore::QualifiedName const&, WTF::AtomString const&, WTF::AtomString const&, WebCore::Element::AttributeModificationReason)
        8   0x12f45a9c8 WebCore::Element::parserSetAttributes(WTF::Vector<WebCore::Attribute, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&)
        9   0x12fbe4690 WebCore::TextControlInnerTextElement::updateInnerTextElementEditabilityImpl(bool, bool)
        10  0x12fbe4484 WebCore::TextControlInnerTextElement::create(WebCore::Document&, bool)
        11  0x12f9dd095 WebCore::HTMLTextAreaElement::didAddUserAgentShadowRoot(WebCore::ShadowRoot&)
        12  0x12f45d051 WebCore::Element::addShadowRoot(WTF::Ref<WebCore::ShadowRoot, WTF::RawPtrTraits<WebCore::ShadowRoot> >&&)
        13  0x12f45dae8 WebCore::Element::createUserAgentShadowRoot()
        14  0x12f45d9fa WebCore::Element::ensureUserAgentShadowRoot()
        15  0x12f9dcf57 WebCore::HTMLTextAreaElement::create(WebCore::QualifiedName const&, WebCore::Document&, WebCore::HTMLFormElement*)
        16  0x12f9dd03b WebCore::HTMLTextAreaElement::create(WebCore::Document&)
        17  0x106b6bd7c TestWebKitAPI::DocumentOrder_Positions_Test::TestBody()
        18  0x1078bdd7b void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        19  0x1078821ca void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*)
        20  0x107882113 testing::Test::Run()
        21  0x107883291 testing::TestInfo::Run()
        22  0x107884334 testing::TestSuite::Run()
        23  0x10789344b testing::internal::UnitTestImpl::RunAllTests()
        24  0x1078c2cbb bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        25  0x107892e0a bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*)
        26  0x107892cf5 testing::UnitTest::Run()
        27  0x106f13e91 RUN_ALL_TESTS()
        28  0x106f13e26 TestWebKitAPI::TestsController::run(int, char**)
        29  0x10784fcc2 main
        30  0x1108a151e

DIFF URL:
https://build.webkit.org/#/builders/374/builds/3231/steps/19/logs/stdio

Comment 1 Radar WebKit Bug Importer 2022-08-18 08:56:00 PDT

<rdar://problem/98834362>

Comment 2 Hercules Hjalmarsson 2022-08-18 08:58:15 PDT

I was able to bisect the issue to 253530@main running command:

run-api-tests TestWebKitAPI.DocumentOrder.Positions

Unable to find builds in proximity to 253530@main. I needed to download them similar to the bots to get test results.

Comment 3 Alexey Proskuryakov 2022-08-18 18:00:57 PDT

This was resolved with a revert in https://commits.webkit.org/253566@main

Comment 4 Ryosuke Niwa 2022-08-18 22:12:06 PDT

Oh, man. This was a really silly issue. The test uses a bunch of WebCore functions directly, and it's stumbling upon XMLNames not being initialized.