Bug 244068

Summary:	Network process should check firstPartyForCookies is an expected URL
Product:	WebKit	Reporter:	Alex Christensen <achristensen>
Component:	WebKit Process Model	Assignee:	Alex Christensen <achristensen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	commit-queue, Hironori.Fujii, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:	244315
Bug Blocks:

Description Alex Christensen 2022-08-17 17:18:58 PDT

More IPC hardening

Comment 1 Alex Christensen 2022-08-17 17:21:23 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3434

Comment 2 EWS 2022-08-23 20:01:34 PDT

Committed 253715@main (c2af5021ad07): <https://commits.webkit.org/253715@main>

Reviewed commits have been landed. Closing PR #3434 and removing active labels.

Comment 3 Radar WebKit Bug Importer 2022-08-23 20:02:17 PDT

<rdar://problem/99063901>

Comment 4 WebKit Commit Bot 2022-08-24 16:53:53 PDT

Re-opened since this is blocked by bug 244315

Comment 5 Alex Christensen 2022-08-25 11:39:56 PDT

This also broke imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html

Comment 6 Alex Christensen 2022-10-10 21:39:25 PDT

Pull request: https://github.com/WebKit/WebKit/pull/5225

Comment 7 EWS 2022-10-11 23:45:19 PDT

Committed 255420@main (361f64fcdd4b): <https://commits.webkit.org/255420@main>

Reviewed commits have been landed. Closing PR #5225 and removing active labels.

Comment 8 Fujii Hironori 2022-11-08 19:54:10 PST

It's been reported the assertion added by this change is failing.

Bug 246858 – [SOUP] http/tests/security/cookies/cookie-theft-with-javascript-doc.html crashing
Bug 247658 – [WinCairo] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies

darinadler added a comment.
https://github.com/WebKit/WebKit/commit/361f64fcdd4b6aa17aaafcc55ebc88ab89acfc89#r87636633
> Why is this assertion correct? I am hitting this assertion while running run-webkit-tests and it’s really slowing down my testing.

Comment 9 Fujii Hironori 2022-11-19 05:53:44 PST

One more.

Bug 248065 – REGRESSION(?): [iOS] ASSERTION FAILED: result in WebKit::NetworkProcess::allowsFirstPartyForCookies()