| Summary: | [LFC][IFC] Add support for out-of-flow content | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, ntim, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=244787 | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
|
Description
zalan
2022-08-17 08:26:02 PDT
Created attachment 461692 [details]
Patch
Created attachment 461693 [details]
Patch
Comment on attachment 461693 [details]
Patch
very nice
Comment on attachment 461693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461693&action=review > Source/WebCore/layout/formattingContexts/inline/InlineFormattingContext.cpp:268 > +static inline std::tuple<const InlineDisplay::Box*, const InlineDisplay::Box*> previousAndNextDisplayBox(const Box& outOfFlowBox, const DisplayBoxes& displayBoxes) 'inline' is probably unnecessary This sound rather generic, maybe it could be something like previousAndNextDisplayBoxForStaticPosition? Created attachment 461700 [details]
Patch
Created attachment 461701 [details]
Patch
Created attachment 461761 [details]
Patch
Created attachment 461767 [details]
Patch
Comment on attachment 461767 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461767&action=review > Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:374 > + auto isSpportedFloatingOrPositioned = [&] (auto& renderer) { typo: isSupportedFloatingOrPositioned Created attachment 461776 [details]
Patch
Committed 253628@main (669ac300289c): <https://commits.webkit.org/253628@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461776 [details]. |