Bug 244006

Summary: Change kdebug check for signposts
Product: WebKit Reporter: Ben Nham <nham>
Component: WebKit Misc.Assignee: Ben Nham <nham>
Status: RESOLVED FIXED    
Severity: Normal CC: nham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 243699    
Bug Blocks:    

Description Ben Nham 2022-08-16 13:29:29 PDT 
In bug 243699 we conditionalized emitting signposts on the result of kdebug_is_enabled for WebKit's DBG_ARIADNE category. However, this ends up enabled in more cases than we'd want, especially on internal builds. This is because the DBG_ARIADNE is enabled by default by tailspin on internal builds. This means signposts are enabled more often than we want, which leads log bloat in the persistent log.

To fix this, we should conditionalize emitting signposts based on a category not included in the default internal tailspin filter instead.
Comment 1 Radar WebKit Bug Importer 2022-08-16 13:30:04 PDT 
<rdar://problem/98745594>
Comment 2 Ben Nham 2022-08-16 13:34:28 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/3373
Comment 3 EWS 2022-08-17 12:32:00 PDT 
Committed 253533@main (74562f9b5ce6): <https://commits.webkit.org/253533@main>

Reviewed commits have been landed. Closing PR #3373 and removing active labels.