Bug 243933

Summary: [LFC][Integration] Paint and hit test RenderInlines with layers
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Antti Koivisto
Reported 2022-08-15 04:22:38 PDT
expand coverage
Attachments
Patch (11.44 KB, patch)
2022-08-15 04:25 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (11.43 KB, patch)
2022-08-15 04:53 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (11.47 KB, patch)
2022-08-15 07:03 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (15.01 KB, patch)
2022-08-15 10:46 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (15.01 KB, patch)
2022-08-15 11:07 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (14.94 KB, patch)
2022-08-15 11:09 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (17.66 KB, patch)
2022-08-15 23:28 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (17.74 KB, patch)
2022-08-15 23:31 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (17.70 KB, patch)
2022-08-16 01:32 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (19.44 KB, patch)
2022-08-16 08:26 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (9) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-08-15 04:23:20 PDT
<rdar://problem/98663584>
Antti Koivisto
Comment 2 2022-08-15 04:25:46 PDT
Created attachment 461633 [details] Patch
Antti Koivisto
Comment 3 2022-08-15 04:53:01 PDT
Created attachment 461634 [details] Patch
Antti Koivisto
Comment 4 2022-08-15 07:03:41 PDT
Created attachment 461635 [details] Patch
alan
Comment 5 2022-08-15 07:57:03 PDT
Comment on attachment 461635 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=461635&action=review v.nice (though a bit unfortunate that RenderInline + layer is so special that it requires the renderer to be passed in to paint and hittest) > COMMIT_MESSAGE:7 > +Add support for painting and hit testing individual renderers. This is neede in the (rare) needed
Antti Koivisto
Comment 6 2022-08-15 10:46:24 PDT
Created attachment 461636 [details] Patch
Antti Koivisto
Comment 7 2022-08-15 11:07:27 PDT
Created attachment 461637 [details] Patch
Antti Koivisto
Comment 8 2022-08-15 11:09:23 PDT
Created attachment 461638 [details] Patch
Antti Koivisto
Comment 9 2022-08-15 11:20:37 PDT
> v.nice (though a bit unfortunate that RenderInline + layer is so special > that it requires the renderer to be passed in to paint and hittest) Yeah. Paint actually gets the layer as part of the paintinfo but hitTest doesn't. I added the argument to both for symmetry until we can do something better.
Antti Koivisto
Comment 10 2022-08-15 23:28:14 PDT
Created attachment 461662 [details] Patch
Antti Koivisto
Comment 11 2022-08-15 23:31:22 PDT
Created attachment 461663 [details] Patch
Antti Koivisto
Comment 12 2022-08-16 01:32:18 PDT
Created attachment 461665 [details] Patch
Antti Koivisto
Comment 13 2022-08-16 08:26:56 PDT
Created attachment 461673 [details] Patch
EWS
Comment 14 2022-08-16 11:57:56 PDT
Committed 253473@main (36f8ddccfef5): <https://commits.webkit.org/253473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461673 [details].
Note You need to log in before you can comment on or make changes to this bug.