Bug 243933

Summary: [LFC][Integration] Paint and hit test RenderInlines with layers
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Antti Koivisto 2022-08-15 04:22:38 PDT 
expand coverage
Comment 1 Radar WebKit Bug Importer 2022-08-15 04:23:20 PDT 
<rdar://problem/98663584>
Comment 2 Antti Koivisto 2022-08-15 04:25:46 PDT 
Created attachment 461633 [details]
Patch
Comment 3 Antti Koivisto 2022-08-15 04:53:01 PDT 
Created attachment 461634 [details]
Patch
Comment 4 Antti Koivisto 2022-08-15 07:03:41 PDT 
Created attachment 461635 [details]
Patch
Comment 5 zalan 2022-08-15 07:57:03 PDT 
Comment on attachment 461635 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=461635&action=review

v.nice (though a bit unfortunate that RenderInline + layer is so special that it requires the renderer to be passed in to paint and hittest)

> COMMIT_MESSAGE:7
> +Add support for painting and hit testing individual renderers. This is neede in the (rare)

needed
Comment 6 Antti Koivisto 2022-08-15 10:46:24 PDT 
Created attachment 461636 [details]
Patch
Comment 7 Antti Koivisto 2022-08-15 11:07:27 PDT 
Created attachment 461637 [details]
Patch
Comment 8 Antti Koivisto 2022-08-15 11:09:23 PDT 
Created attachment 461638 [details]
Patch
Comment 9 Antti Koivisto 2022-08-15 11:20:37 PDT 
> v.nice (though a bit unfortunate that RenderInline + layer is so special
> that it requires the renderer to be passed in to paint and hittest)

Yeah. Paint actually gets the layer as part of the paintinfo but hitTest doesn't. I added the argument to both for symmetry until we can do something better.
Comment 10 Antti Koivisto 2022-08-15 23:28:14 PDT 
Created attachment 461662 [details]
Patch
Comment 11 Antti Koivisto 2022-08-15 23:31:22 PDT 
Created attachment 461663 [details]
Patch
Comment 12 Antti Koivisto 2022-08-16 01:32:18 PDT 
Created attachment 461665 [details]
Patch
Comment 13 Antti Koivisto 2022-08-16 08:26:56 PDT 
Created attachment 461673 [details]
Patch
Comment 14 EWS 2022-08-16 11:57:56 PDT 
Committed 253473@main (36f8ddccfef5): <https://commits.webkit.org/253473@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 461673 [details].