Bug 243856

Summary:

REGRESSION (r288159): Tables layout broken on WPT.FYI

Product:

WebKit

Reporter:

Ahmad Saleem <ahmad.saleem792>

Component:

Tables

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, gsnedders, koivisto, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

Safari 15

Hardware:

Unspecified

OS:

Unspecified

URL:

https://wpt.fyi/results/svg/idlharness.window.html?label=experimental&label=master&aligned&view=subtest

Attachments:

Description	Flags
Safari 15.6 vs STP 151	none
Test reduction	none
Patch	none
Patch	none
wpt page fixed with the patch	none
Patch	none

Ahmad Saleem

Reported 2022-08-11 16:21:39 PDT

Hi Team, After STP 151 release, I noted that the WPT test case layout is broken on following link: Link - https://wpt.fyi/results/svg/idlharness.window.html?label=experimental&label=master&aligned&view=subtest Please refer to attached screenshot for Safari 15.6 behavior vs STP 151 behavior. Unfortunately, I don't have reduction or which bug caused it or whether it is website not following specs. Thanks!

Attachments
Safari 15.6 vs STP 151 (1.57 MB, image/png) 2022-08-11 16:23 PDT, Ahmad Saleem	no flags	Details
Test reduction (141 bytes, text/html) 2022-08-12 07:09 PDT, alan	no flags	Details
Patch (7.73 KB, patch) 2022-08-12 21:19 PDT, alan	no flags	Details Formatted Diff Diff
Patch (7.75 KB, patch) 2022-08-12 21:20 PDT, alan	no flags	Details Formatted Diff Diff
wpt page fixed with the patch (1.22 MB, image/png) 2022-08-12 21:21 PDT, alan	no flags	Details
Patch (11.93 KB, patch) 2022-08-13 07:55 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ahmad Saleem

Comment 1 2022-08-11 16:23:24 PDT

Created attachment 461551 [details] Safari 15.6 vs STP 151 For reference to see broken view.

Radar WebKit Bug Importer

Comment 2 2022-08-11 16:38:57 PDT

<rdar://problem/98537484>

alan

Comment 3 2022-08-11 16:52:34 PDT

regressed at r288159. preferred width computation.

Alexey Proskuryakov

Comment 4 2022-08-11 17:10:51 PDT

That revision landed 7 months ago, can it be an STP 151 regression?

alan

Comment 5 2022-08-11 17:57:46 PDT

(In reply to Alexey Proskuryakov from comment #4) > That revision landed 7 months ago, can it be an STP 151 regression? certainly not an STP 151 regression.

Ahmad Saleem

Comment 6 2022-08-12 04:12:37 PDT

Can I download STP 150 from any website to check if it is recent regression or it is broken since 7 months? I really doubt, it is broken since 7 months since even Safari 15.6 includes fixes from Safari TP 148 as per blog post: Link - https://webkit.org/blog/13009/new-webkit-features-in-safari-15-6/ Which was only released 29 June 2022, approx. two months ago.. zalan@webkit.org - I am not saying you are wrong but I just want to help and give better bug report for it is easier to fix. Hence, just asking this question and stuff. Thanks!

alan

Comment 7 2022-08-12 06:56:13 PDT

(In reply to Ahmad Saleem from comment #6) > Can I download STP 150 from any website to check if it is recent regression > or it is broken since 7 months? > > I really doubt, it is broken since 7 months since even Safari 15.6 includes > fixes from Safari TP 148 as per blog post: > > Link - https://webkit.org/blog/13009/new-webkit-features-in-safari-15-6/ > > Which was only released 29 June 2022, approx. two months ago.. > > zalan@webkit.org - I am not saying you are wrong but I just want to help and > give better bug report for it is easier to fix. Hence, just asking this > question and stuff. Thanks! Thank you, I really appreciate it!

alan

Comment 8 2022-08-12 07:09:30 PDT

Created attachment 461560 [details] Test reduction This bugs is specific about about incorrect minimum width computations on content starting with punctuation and no wrapping opportunities (e.g. !INHERITS(getEnclosureList) ) combined with "let's break the content at any arbitrary position (word-break: break-all)". "x!pass_if_this_line_wraps", is supposed to return the width of 'x!' as the minimum width (can't break in-between "x" and "!". However we completely fail to break the content and return the total content width as the minimum width (so min width == max width). This confuses flexing type of layouts (e.g. table) and produces wide columns.

alan

Comment 9 2022-08-12 21:19:23 PDT

Created attachment 461571 [details] Patch

alan

Comment 10 2022-08-12 21:20:24 PDT

Created attachment 461572 [details] Patch

alan

Comment 11 2022-08-12 21:21:59 PDT

Created attachment 461573 [details] wpt page fixed with the patch

alan

Comment 12 2022-08-13 07:55:19 PDT

Created attachment 461576 [details] Patch

EWS

Comment 13 2022-08-15 12:21:34 PDT

Committed 253434@main (17ac2cd774fd): <https://commits.webkit.org/253434@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 461576 [details].

Note You need to log in before you can comment on or make changes to this bug.