Bug 243846

Summary: [WPE] wpe_input_keyboard_event in public API
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: bugs-noreply
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   

Description Michael Catanzaro 2022-08-11 14:00:23 PDT
There is a comment in WebKitWebView.h:

    gboolean   (* context_menu)                (WebKitWebView               *web_view,
                                                WebKitContextMenu           *context_menu,
                                                void                        *event, /* FIXME: Use a wpe thing here. I'm not sure we want to expose libwpe in the API. */
                                                WebKitHitTestResult         *hit_test_result);

which indicates hesitation to expose libwpe types in the public API, a worthy goal since that results in the function being non-introspectable. Sadly, struct wpe_input_keyboard_event is actually exposed in two places in WebKitInputMethodContext.