Bug 243824

Summary:	WebKit::terminateWithReason() is declared in WebKit/Platform/spi, but defined in WebKit/Shared
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	WebKit2	Assignee:	Kimmo Kinnunen <kkinnunen>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	kkinnunen, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	Other
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	243780

Description Kimmo Kinnunen 2022-08-11 07:08:25 PDT

WebKit::terminateWithReason() is declared in WebKit/Platform/spi, but defined in WebKit/Shared

Problems:
 - IPC:: uses WebKit::terminateWithReason(), but terminateWithReason() is not implemented in WebKit/Platform
 - WebKit::terminateWithReason() is declared in a SPI header. Typically SPI headers only declare the SPI.
 - WebKit::terminateWithReason() is defined in a surprising file (ProcessLauncherCocoa.mm)

The layering violation of WebKit/Platform depending on WebKit/Shared implementation is making it hard to compile a version of IPC that does not depend on WebKit:: other that WebKit/Platform.

Comment 1 Radar WebKit Bug Importer 2022-08-11 07:09:51 PDT

<rdar://problem/98506618>

Comment 2 Kimmo Kinnunen 2022-08-11 07:29:15 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3219

Comment 3 EWS 2022-08-16 01:22:30 PDT

Committed 253461@main (7e6b014c2242): <https://commits.webkit.org/253461@main>

Reviewed commits have been landed. Closing PR #3219 and removing active labels.