| Summary: | Handle transform changes causing overflow updates | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Nguyen (:ntim) <ntim> | ||||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
| Status: | REOPENED --- | ||||||||||||
| Severity: | Normal | CC: | bfulgham, changseok, commit-queue, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 248959 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tim Nguyen (:ntim)
2022-08-10 20:39:26 PDT
I think these tests are affected too: css/css-transforms/transform-transformed-tbody-contains-fixed-position.html css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html css/css-transforms/transform-transformed-thead-contains-fixed-position.html Created attachment 462258 [details]
Patch
Comment on attachment 462258 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=462258&action=review > Source/WebCore/rendering/RenderElement.cpp:258 > + diff = std::max(diff, StyleDifference::SimplifiedLayout); I wonder if we can clean up code around this FIXME: https://searchfox.org/wubkat/rev/7111cbd9fd80f1b153ea0d0a1805420bae87211c/Source/WebCore/rendering/RenderLayerCompositor.cpp#1775 fast/repaint/multiple-backgrounds-style-change.html ^^ background image repaint optimization fails. We should certainly be able to identify this no-repaint case when there's no change in overflow. Created attachment 462873 [details]
Patch
Created attachment 462876 [details]
Patch
Created attachment 462918 [details]
[fast-cq]Patch
Committed 255406@main (fc014916474a): <https://commits.webkit.org/255406@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462918 [details]. Re-opened since this is blocked by bug 248959 |