| Summary: | Implement list of available images matching logic | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | Images | Assignee: | Przemyslaw Gorszkowski <pgorszkowski> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, domfarolino, ews-watchlist, Hironori.Fujii, japhet, sabouhallawa, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | Safari 15 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2022-08-10 10:16:35 PDT
Created attachment 461530 [details]
Patch
Created attachment 461541 [details]
Patch
Created attachment 461562 [details]
Patch
Pull request: https://github.com/WebKit/WebKit/pull/3534 @domfarolino Could you have a look at the patch? In particular I am not sure how the HTML preloader fits in with the matching logic, is there anything in the spec related to this? Where should I respond? Here or on GitHub? Pull request: https://github.com/WebKit/WebKit/pull/18271 Committed 269243@main (873115a0db74): <https://commits.webkit.org/269243@main> Reviewed commits have been landed. Closing PR #18271 and removing active labels. http/tests/lazyload/lazy.html is failing after 269243@main. https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Flazyload%2Flazy.html It seems that memory cache is not reset between tests, that is why this test fails (the image is load from memory cache in case of img with loading='lazy'). If I run test as single test: Tools/Scripts/run-webkit-tests --gtk LayoutTests/http/tests/lazyload/lazy.html the test passes. I will check how it can be fixed. I created a separate bug report about it: https://bugs.webkit.org/show_bug.cgi?id=263131 |