Bug 243790

Summary: Implement list of available images matching logic
Product: WebKit Reporter: Rob Buis <rbuis>
Component: ImagesAssignee: Przemyslaw Gorszkowski <pgorszkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, domfarolino, ews-watchlist, fujii.hironori, japhet, sabouhallawa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Safari 15   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2022-08-10 10:16:35 PDT
Implement list of available images matching logic: https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:list-of-available-images
Attachments
Patch (5.82 KB, patch)
2022-08-10 10:18 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (5.85 KB, patch)
2022-08-11 04:04 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2022-08-12 08:50 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2022-08-10 10:18:21 PDT
Created attachment 461530 [details] Patch
Rob Buis
Comment 2 2022-08-11 04:04:39 PDT
Created attachment 461541 [details] Patch
Rob Buis
Comment 3 2022-08-12 08:50:42 PDT
Created attachment 461562 [details] Patch
Radar WebKit Bug Importer
Comment 4 2022-08-17 10:17:15 PDT
<rdar://problem/98788086>
Rob Buis
Comment 5 2022-08-22 06:52:42 PDT
Pull request: https://github.com/WebKit/WebKit/pull/3534
Rob Buis
Comment 6 2022-08-22 07:06:04 PDT
@domfarolino Could you have a look at the patch? In particular I am not sure how the HTML preloader fits in with the matching logic, is there anything in the spec related to this?
Dominic Farolino
Comment 7 2022-08-24 17:36:45 PDT
Where should I respond? Here or on GitHub?
Przemyslaw Gorszkowski
Comment 8 2023-09-27 04:52:37 PDT
Pull request: https://github.com/WebKit/WebKit/pull/18271
EWS
Comment 9 2023-10-12 00:39:47 PDT
Committed 269243@main (873115a0db74): <https://commits.webkit.org/269243@main> Reviewed commits have been landed. Closing PR #18271 and removing active labels.
Fujii Hironori
Comment 10 2023-10-13 04:04:55 PDT
http/tests/lazyload/lazy.html is failing after 269243@main. https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Flazyload%2Flazy.html
Przemyslaw Gorszkowski
Comment 11 2023-10-13 11:01:11 PDT
It seems that memory cache is not reset between tests, that is why this test fails (the image is load from memory cache in case of img with loading='lazy'). If I run test as single test: Tools/Scripts/run-webkit-tests --gtk LayoutTests/http/tests/lazyload/lazy.html the test passes. I will check how it can be fixed.
Przemyslaw Gorszkowski
Comment 12 2023-10-13 12:23:33 PDT
I created a separate bug report about it: https://bugs.webkit.org/show_bug.cgi?id=263131
Note You need to log in before you can comment on or make changes to this bug.