Bug 243699
| Summary: | Enable os_signposts on all builds | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Nham <nham> |
| Component: | WebKit Misc. | Assignee: | Ben Nham <nham> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | nham, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 244006 | ||
Ben Nham
Currently WebKit's os_signposts are only enabled on AppleInternal builds. The idea was that sensitive content might be included in the signposts which should only be logged on internal builds. But this is the wrong way of achieving that goal, as we can use the standard logging privacy specifiers to control content that should be redacted from signposts. This also makes it hard to enable the signposts on perf test bots that emulate standard OS builds.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/98348637>
Ben Nham
Pull request: https://github.com/WebKit/WebKit/pull/3125
EWS
Committed 253387@main (860f2d7753d1): <https://commits.webkit.org/253387@main>
Reviewed commits have been landed. Closing PR #3125 and removing active labels.