Bug 243690

Summary:	REGRESSION (252960@main): [ iOS ] Four imported/w3c/web-platform-tests/html/cross-origin-opener-policy tests are a consistent/flaky failure
Product:	WebKit	Reporter:	Karl Rackler <rackler>
Component:	New Bugs	Assignee:	Chris Dumez <cdumez>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	cdumez, hhjalmarsson, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified

Description Karl Rackler 2022-08-08 14:17:25 PDT

Description:
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-unsafe-none-to-same-origin.https.html
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/javascript-url.https.html
imported/w3c/web-platform-tests/html/cross-origin-opener-policy/tentative/restrict-properties/iframe-popup-to-so.https.html

The most recent failure after a series of consistent passes for iOS that I see on the dashboard was on 7/29/2022 at 252966@main.  The tests are constant failures on [ iOS Debug ] x86_64 and flaky failures on [ iOS Release ] x86_64.

REPRODUCTION STEPS
I can reproduce this on 252960@main but cannot reproduce it on 252959@main or earlier.

Command: 
run-webkit-tests --ios-simulator --debug --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --iterations 50 --no-retry imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html

Result: 
Regressions: Unexpected text-only failures (1)
  imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html [ Failure ]

History:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcross-origin-opener-policy%2Fiframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcross-origin-opener-policy%2Fiframe-popup-unsafe-none-to-same-origin.https.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcross-origin-opener-policy%2Fjavascript-url.https.html&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fcross-origin-opener-policy%2Ftentative%2Frestrict-properties%2Fiframe-popup-to-so.https.html&limit=50000&platform=ios&architecture=x86_64

Diff:
--- /Volumes/Data/worker/Apple-iOS-15-Simulator-Debug-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https-expected.txt
+++ /Volumes/Data/worker/Apple-iOS-15-Simulator-Debug-WK2-Tests/build/layout-test-results/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/iframe-popup-same-origin-allow-popups-to-same-origin-allow-popups.https-actual.txt
@@ -1,3 +1,6 @@
+
+
+Harness Error (TIMEOUT), message = null
 
 PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, same origin popup with window_open
 PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, same origin popup with anchor
@@ -15,15 +18,15 @@
 PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, same site popup with anchor
 PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, same site popup with form
 PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, same site popup with window_open
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, same site popup with anchor
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, same site popup with form
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with window_open
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with anchor
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with form
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with window_open
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with anchor
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with form
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with window_open
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with anchor
-PASS COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with form
+TIMEOUT COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, same site popup with anchor Test timed out
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, same site popup with form
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with window_open
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with anchor
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same origin iframe, cross origin popup with form
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with window_open
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with anchor
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with same site iframe, cross origin popup with form
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with window_open
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with anchor
+NOTRUN COOP: same-origin-allow-popups to popup COOP: same-origin-allow-popups via an iframe, with cross origin iframe, cross origin popup with form

Comment 1 Radar WebKit Bug Importer 2022-08-08 14:17:47 PDT

<rdar://problem/98340758>

Comment 2 Karl Rackler 2022-08-08 14:30:21 PDT

The change happened after a WPT resync of html tests from upstream.  The tests went from consistently passing to constant failures on [ iOS Debug ] x86_64 and flaky failures on [ iOS Release ] x86_64.

Comment 3 Karl Rackler 2022-08-08 15:49:57 PDT

I have marked these tests as a flaky failure while this issue is investigated.

Comment 4 EWS 2022-08-08 15:54:37 PDT

Test gardening commit 253237@main (8aaa9c5b0c81): <https://commits.webkit.org/253237@main>

Reviewed commits have been landed. Closing PR #3120 and removing active labels.

Comment 5 Hercules Hjalmarsson 2022-08-09 16:41:46 PDT

*** Bug 243734 has been marked as a duplicate of this bug. ***

Comment 6 Chris Dumez 2022-11-04 16:42:51 PDT

Pull request: https://github.com/WebKit/WebKit/pull/6156

Comment 7 EWS 2022-11-05 11:26:59 PDT

Committed 256358@main (689669ffb8f4): <https://commits.webkit.org/256358@main>

Reviewed commits have been landed. Closing PR #6156 and removing active labels.

Comment 8 Chris Dumez 2022-11-07 15:51:44 PST

Reverted by https://github.com/WebKit/WebKit/pull/6228

Comment 9 Chris Dumez 2022-11-07 15:51:48 PST

Re-opening for pull request https://github.com/WebKit/WebKit/pull/6228

Comment 10 EWS 2022-11-07 15:57:28 PST

Committed 256429@main (f344e17405d4): <https://commits.webkit.org/256429@main>

Reviewed commits have been landed. Closing PR #6228 and removing active labels.