Bug 243680

Summary:

Apply C++ type safety to Lookup.h's HashTableValue's ValueStorage union.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, beidson, benjamin, calvaris, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, jsbell, keith_miller, msaboff, ryuan.choi, saam, sergio, tzagallo, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP for EWS testing.	ews-feeder: commit-queue-
WIP for EWS testing.	none
WIP for EWS testing.	none
WIP for EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	ews-feeder: commit-queue-
EWS testing.	none

Mark Lam

Reported 2022-08-08 12:15:18 PDT

This will help make the code cleaner and easier to reason about.

Attachments
WIP for EWS testing. (102.96 KB, patch) 2022-08-08 12:16 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP for EWS testing. (575.98 KB, patch) 2022-08-08 12:30 PDT, Mark Lam	no flags	Details Formatted Diff Diff
WIP for EWS testing. (577.87 KB, patch) 2022-08-08 12:52 PDT, Mark Lam	no flags	Details Formatted Diff Diff
WIP for EWS testing. (577.89 KB, patch) 2022-08-08 12:58 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (608.26 KB, patch) 2022-08-09 22:26 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (609.26 KB, patch) 2022-08-09 23:16 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (605.03 KB, patch) 2022-08-10 11:15 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (605.13 KB, patch) 2022-08-10 11:51 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (593.12 KB, patch) 2022-08-10 15:10 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (613.32 KB, patch) 2022-08-13 13:44 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (595.45 KB, patch) 2022-08-13 14:03 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
EWS testing. (597.47 KB, patch) 2022-08-13 23:49 PDT, Mark Lam	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2022-08-08 12:16:58 PDT

Created attachment 461487 [details] WIP for EWS testing.

Mark Lam

Comment 2 2022-08-08 12:30:53 PDT

Created attachment 461488 [details] WIP for EWS testing.

Mark Lam

Comment 3 2022-08-08 12:52:19 PDT

Created attachment 461489 [details] WIP for EWS testing.

Mark Lam

Comment 4 2022-08-08 12:58:01 PDT

Created attachment 461490 [details] WIP for EWS testing.

Mark Lam

Comment 5 2022-08-08 14:12:15 PDT

<rdar://problem/98206776>

Mark Lam

Comment 6 2022-08-08 14:53:06 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3118

Mark Lam

Comment 7 2022-08-09 22:26:35 PDT

Created attachment 461521 [details] EWS testing.

Mark Lam

Comment 8 2022-08-09 23:16:40 PDT

Created attachment 461522 [details] EWS testing.

Mark Lam

Comment 9 2022-08-10 11:15:19 PDT

Created attachment 461532 [details] EWS testing.

Mark Lam

Comment 10 2022-08-10 11:51:05 PDT

Created attachment 461535 [details] EWS testing.

Mark Lam

Comment 11 2022-08-10 15:10:54 PDT

Created attachment 461538 [details] EWS testing.

Mark Lam

Comment 12 2022-08-13 13:44:19 PDT

Created attachment 461597 [details] EWS testing.

Mark Lam

Comment 13 2022-08-13 14:03:47 PDT

Created attachment 461598 [details] EWS testing.

Mark Lam

Comment 14 2022-08-13 23:49:49 PDT

Created attachment 461605 [details] EWS testing.

EWS

Comment 15 2022-08-14 16:57:48 PDT

Committed 253414@main (757f991622c7): <https://commits.webkit.org/253414@main> Reviewed commits have been landed. Closing PR #3118 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.